Update nested_inputs.py#315
Merged
Merged
Conversation
NLaws
approved these changes
Apr 18, 2022
Member
NLaws
left a comment
NLaws
left a comment
There was a problem hiding this comment.
This max value is not used in optimization right so it doesn't matter how big it is?
Collaborator
Author
Correct! It's not used in the optimization, it only limits the user's input. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
(Bug fix, feature, docs update, ...)
Increases the max value of
other_capital_costs_us_dollarsto 1.0e10 innested_inputs.py.What is the current behavior?
(You can also link to an open issue here)
Was set to max_big_number (1.0e8).
What is the new behavior (if this is a feature change)?
Set to 1.0e10
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
No.
Other information:
I am running off-grid microgrid analyses for Kenya, and some of the capital costs exceed the current upper bound.