Outage timestep corrections#313
Merged
Merged
Conversation
missing -1 in indexing was causing BAU problem to be infeasible when existing techs could sustain part of outage
NLaws
requested changes
Mar 29, 2022
Member
NLaws
left a comment
NLaws
left a comment
There was a problem hiding this comment.
Please update the test re: my inline comment.
NLaws
requested changes
Apr 25, 2022
Member
NLaws
left a comment
NLaws
left a comment
There was a problem hiding this comment.
Please add a description to the doc string of test_critical_load_bau_can_sustain_part_outage of what is being tested so that we do not have to read the test line by line to understand what it is doing. Can you please describe the blocks of calculations with comments? Is it only testing BAU values? (If so when we put it in REopt.jl we could run just a BAU scenario). It looks like pwf_om is calculated but not used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
bug fix
What is the current behavior?
When normal and critical load profiles are spliced together for the BAU problem (and zeroed out after the time steps that BAU techs can sustain), missing minus ones in indexing is causing BAU problem to be infeasible when existing techs can sustain part but not all of outage.
What is the new behavior (if this is a feature change)?
The spliced load passed to the BAU problem contains the critical load in the outage time steps up to t (where t is the last consecutive time step that the existing techs can meet load) and zeros in the outage time steps after that.
Does this PR introduce a breaking change?
no
Other information: