Ghp breaking updates#265
Merged
Merged
Conversation
Move from load_profile, and make DRY using this in BuiltInProfile.city property
Also move the default data into ghpghx/models.py
Unneeded separate classes with how they were used
…p_uuid in the reo GHP inputs Before, this data was being stored in both /ghpghx models and /reo models inside of GHP.ghpghx_response.
Collaborator
Author
|
@NLaws I forgot I actually branched off of |
3 tasks
Issue caused by changing heating load data locations
Collaborator
Author
|
@NLaws I addressed this comment from PR 257 to add a README.md to /input_files/LoadProfiles |
NLaws
approved these changes
Sep 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a lot of the bigger comments on PR 257 related to db models, GHP classes, and endpoints.