Skip to content

Add supplementary firing costs#262

Merged
Bill-Becker merged 34 commits into
ghpfrom
add-supplementary-firing-costs
Sep 23, 2021
Merged

Add supplementary firing costs#262
Bill-Becker merged 34 commits into
ghpfrom
add-supplementary-firing-costs

Conversation

@zolanaj
Copy link
Copy Markdown
Collaborator

@zolanaj zolanaj commented Sep 18, 2021

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Feature: this PR adds a capital cost to the supplementary duct firing system that allows CHP systems to produce more heat than that which is captured via the prime mover when generating electricity.

What is the current behavior?

  • Supplementary firing is included and incurs a cost according to the thermal efficiency of the system, but no capital cost for this add-on exists.
  • Supplementary firing thermal production is not included in thermal output summary.

What is the new behavior (if this is a feature change)?

  • Capital cost per kW of the supplementary firing system has been added as a new input, and the size of the supplementary firing system in the solution has been added as an output.
  • A new binary variable and continuous variable have been added to the optimization model; the former is 1 if supplementary firing is included with the CHP system and 0 otherwise, while the second represents the size of the supplementary firing system.
  • A collection of constraints have been added so that the size of the supplementary firing system is equal to the CHP system size if any supplementary firing is used, and zero otherwise.
  • Supplementary firing thermal production is combined with the CHP prime mover heat capture in tracking CHP thermal production as a combined statistic (It's not currently separated in the outputs).

Does this PR introduce a breaking change?

No

Other information:

  • Capital cost calculation is included in the initial capex costing when processing outputs.
  • Thermal production from supplementary firing isn't tracked separately anywhere in the Julia outputs right now.

uses existing constraint instead of originally added one
@zolanaj zolanaj requested a review from Bill-Becker September 18, 2021 02:45
@Bill-Becker
Copy link
Copy Markdown
Collaborator

@zolanaj Thanks for doing a very thorough job adding this feature to the API! It probably took you longer than expected. I just made one name change: dvSupplementaryThermalSize changed to dvSupplementaryFiringCHPSize to clarify that it's not a thermal size of the supplementary firing but instead the CHP size used for supplementary firing.

@Bill-Becker
Copy link
Copy Markdown
Collaborator

@zolanaj Please review the last two commits for the addition of one constraint and the reduction of 2 others into one indicator-style constraint (we are trying to use those where applicable).

@Bill-Becker Bill-Becker merged commit de772dd into ghp Sep 23, 2021
@Bill-Becker Bill-Becker deleted the add-supplementary-firing-costs branch September 23, 2021 14:19
Copy link
Copy Markdown
Collaborator

@Bill-Becker Bill-Becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@zolanaj
Copy link
Copy Markdown
Collaborator Author

zolanaj commented Sep 24, 2021

@Bill-Becker thanks for these! Your updates look good to me, and I'll implement indicator constraints in this format moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants