Add supplementary firing costs#262
Merged
Merged
Conversation
uses existing constraint instead of originally added one
…iary variable if not met
…REL/REopt_Lite_API into add-supplementary-firing-costs
Collaborator
|
@zolanaj Thanks for doing a very thorough job adding this feature to the API! It probably took you longer than expected. I just made one name change: |
Without this, dvSupplementaryFiringCHPSize can be zero and still get y-int amount of heat extra
Collaborator
|
@zolanaj Please review the last two commits for the addition of one constraint and the reduction of 2 others into one indicator-style constraint (we are trying to use those where applicable). |
Collaborator
Author
|
@Bill-Becker thanks for these! Your updates look good to me, and I'll implement indicator constraints in this format moving forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Feature: this PR adds a capital cost to the supplementary duct firing system that allows CHP systems to produce more heat than that which is captured via the prime mover when generating electricity.
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
No
Other information: