Skip to content

Move token request URI generation into TokenRequest#2

Merged
iainmcgin merged 1 commit intoopenid:masterfrom
iainmcgin:tokenuri
Feb 27, 2016
Merged

Move token request URI generation into TokenRequest#2
iainmcgin merged 1 commit intoopenid:masterfrom
iainmcgin:tokenuri

Conversation

@iainmcgin
Copy link
Member

After this, we can remove all parameter related code from AuthorizationService.

Review on Reviewable

@iainmcgin
Copy link
Member Author

+@WilliamDenniss for review


Review status: 0 of 5 files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@tikurahul
Copy link
Collaborator

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@tikurahul
Copy link
Collaborator

LGTM


Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from the review on Reviewable.io

iainmcgin added a commit that referenced this pull request Feb 27, 2016
Move token request URI generation into TokenRequest
@iainmcgin iainmcgin merged commit f02da65 into openid:master Feb 27, 2016
Copy link

@QQn00bs QQn00bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Q

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants