Skip to content

Fix completion signature detection with GCC 13.1 and 13.2 - #2280

Merged
ericniebler merged 1 commit into
NVIDIA:mainfrom
MaxFreedomPollard:fix/gcc-13-completion-signatures
Sep 23, 2026
Merged

ericniebler merged 1 commit into
NVIDIA:mainfrom
MaxFreedomPollard:fix/gcc-13-completion-signatures

Conversation

@MaxFreedomPollard

Copy link
Copy Markdown
Contributor

GCC 13.1 and 13.2 still give the class-type completion-signatures template argument a const-qualified type, so they need the existing remove_const_t workaround too. Extend its upper bound to GCC 13.3, where the unqualified check works.

Fixes #2078.

Validation:

  • The issue's sender_in reproducer fails on unchanged main with GCC 13.1 and 13.2. With this change, it compiles with -std=c++20 -Wall -Wextra -Werror and an inline_scheduler / then / start_detached pipeline runs successfully.
  • GCC 13.3 compiles and runs the same program both before and after the change.
  • The existing test.stdexec suite passes with Apple Clang: 622 test cases, 3,522 assertions.

@copy-pr-bot

copy-pr-bot Bot commented Sep 20, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ericniebler

Copy link
Copy Markdown
Collaborator

/ok to test 5f13449

@ericniebler
ericniebler merged commit 249de1e into NVIDIA:main Sep 23, 2026
39 checks passed
@ericniebler

Copy link
Copy Markdown
Collaborator

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sender_in fails with GCC 13.1 due to const completion_signatures in __constant_completion_signatures_v

2 participants