Skip to content

Use built-in types rather than typing aliases for type annotations #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 10 commits into from
Closed

Use built-in types rather than typing aliases for type annotations #892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2df223b
Initial plan
Copilot Aug 22, 2025
cf0fe91
Replace typing aliases with built-in types for Python 3.9+
Copilot Aug 22, 2025
d9e335d
Enable modern typing linting rules after modernization
Copilot Aug 22, 2025
31b795d
Extend typing modernization to Cython .pyx.in files
Copilot Aug 22, 2025
4329941
Fix missed Tuple annotation in _stream.pyx file
Copilot Aug 22, 2025
5653337
Fix remaining Tuple usage in utils.pyx.in isinstance check
Copilot Aug 22, 2025
07fe604
Fix variable name replacements and extend typing modernization to .px…
Copilot Aug 22, 2025
37e37be
Fix variable name casing errors in List/Tuple replacement
Copilot Aug 22, 2025
f3213cd
Fix exception string tests to use modernized tuple type annotations
Copilot Aug 22, 2025
68c220b
Merge branch 'main' into copilot/fix-891
mdboom Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions cuda_bindings/cuda/bindings/_lib/utils.pyx.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ from libc.stdint cimport int32_t, uint32_t, int64_t, uint64_t
from libc.stddef cimport wchar_t
from libc.string cimport memcpy
from enum import Enum
from typing import List, Tuple
import ctypes
cimport cuda.bindings.cydriver as cydriver
import cuda.bindings.driver as driver
Expand Down Expand Up @@ -58,7 +57,7 @@ cdef class HelperKernelParams:
raise RuntimeError("Argument 'kernelParams' failed to retrieve buffer through Buffer Protocol")
self._pyobj_acquired = True
self._ckernelParams = <void**><void_ptr>self._pybuffer.buf
elif isinstance(kernelParams, (Tuple)) and len(kernelParams) == 2 and isinstance(kernelParams[0], (Tuple)) and isinstance(kernelParams[1], (Tuple)):
elif isinstance(kernelParams, (tuple)) and len(kernelParams) == 2 and isinstance(kernelParams[0], (tuple)) and isinstance(kernelParams[1], (tuple)):
# Hard run, construct and fill out contigues memory using provided kernel values and types based
if len(kernelParams[0]) != len(kernelParams[1]):
raise TypeError("Argument 'kernelParams' has tuples with different length")
Expand Down Expand Up @@ -117,7 +116,7 @@ cdef class HelperKernelParams:
raise TypeError("Unsupported type: " + str(type(ctype)))
idx += 1
else:
raise TypeError("Argument 'kernelParams' is not a valid type: Tuple[Tuple[Any, ...], Tuple[Any, ...]] or PyObject implimenting Buffer Protocol or Int")
raise TypeError("Argument 'kernelParams' is not a valid type: tuple[tuple[Any, ...], tuple[Any, ...]] or PyObject implimenting Buffer Protocol or Int")

def __dealloc__(self):
if self._pyobj_acquired is True:
Expand Down
Loading