test(cuda.core): skip CUDA-GL interop tests on TCC devices - #3054

Hm, the test_graphics_apis.py tests do not need the same skip?

@coderabbitai Do you know?

#!/bin/bash
ast-grep outline cuda_bindings/tests/test_graphics_apis.py --items all
rg -n -C3 'tcc|TCC|open_gl_window|is_gl_context_unavailable|cuGL|cuGraphics|skip|fixture' cuda_bindings/tests/test_graphics_apis.py
fd -i '^graphics\.py$'

#!/bin/bash
sed -n '55,150p' cuda_bindings/tests/test_graphics_apis.py
ast-grep outline cuda_python_test_helpers/cuda_python_test_helpers/graphics.py --items all
rg -n -A45 -B3 '^def (is_gl_context_unavailable|open_gl_window)\(' cuda_python_test_helpers/cuda_python_test_helpers/graphics.py
rg -n -C3 'cudaDevAttrTccDriver|CU_DEVICE_ATTRIBUTE_TCC_DRIVER|cudaDeviceGetAttribute\(|cudaGetDevice\(' cuda_bindings/tests --glob '*.py'

@juenglin suggestion: Yes—the GL smoke tests need the same early TCC skip.

In cuda_bindings/tests/test_graphics_apis.py, _gl_context() calls open_gl_window() without checking TCC mode. The reported GLException would propagate before the test reaches its cudaErrorOperatingSystem handling. Both parameterizations of test_cuda_gl_register_image_smoketest use this path.

Add the check before _configure_pyglet_headless(). Use cudart.cudaGetDevice() and cudart.cudaDeviceGetAttribute(cudart.cudaDeviceAttr.cudaDevAttrTccDriver, device) to avoid a dependency on cuda.core. Check both return statuses; query failures should fail, not skip.

Keep test_cuda_register_image_invalid enabled. It does not create a GL context and only checks that registration with an invalid handle returns an error.

This conclusion comes from code inspection. I did not test it on TCC hardware.

You are interacting with an AI system.

Would it be better to work the skip into is_gl_context_unavailable then?

#!/bin/bash
ast-grep outline cuda_python_test_helpers/cuda_python_test_helpers/graphics.py --items all
ast-grep outline cuda_bindings/tests/test_graphics_apis.py --items all
rg -n -A65 -B3 '^def (is_gl_context_unavailable|open_gl_window)\(' cuda_python_test_helpers/cuda_python_test_helpers/graphics.py
rg -n -A55 -B3 '^def (_gl_context|_configure_pyglet_headless)\(' cuda_bindings/tests/test_graphics_apis.py

@juenglin suggestion: Share the TCC check, but keep it separate from is_gl_context_unavailable().

That function classifies an exception after GL setup fails. TCC is a property of the selected CUDA device, so check it before GL setup. A GL context could also open on another GPU even when the selected CUDA device uses TCC.

Do not add generic GLException handling. The helper deliberately rejects it because it can indicate a real GL error.

A separate helper in cuda_python_test_helpers.graphics could return a skip reason for TCC. Both test suites could call it before configuring pyglet or opening a window. Use cuda.bindings for the device query, rather than introducing a cuda.core dependency. Let query failures propagate.

You are interacting with an AI system.

@coderabbitai Please make the change you suggested.

📌 Tracking this review finding. CodeRabbit will verify future changes against the original feedback and will only mark it fixed when the code satisfies it.

✅ Fixed in #3054.