You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[DOC]: CUDA Python 12.9.1 Release notes are incomplete #825
Updating from older versions (v12.6.2.post1 and below) via pip install -U cuda-python might not work. Please do a clean re-installation by uninstalling pip uninstall -y cuda-python followed by installing pip install cuda-python.
But the diff between 12.9.0 and 12.9.1 looks more like major release rather than patch release: v12.9.0...v12.9.1
If this is a correction, please provide a link to the incorrect documentation. If this is a new documentation request, please link to where you have looked.
These are expected because of the way this repository is set up to host multiple component packages. The diff is inevitably affected by other components that are considered irrelevant to the new tag (in this case, cuda.core).
As for the cuda-python release note, I have two comments:
As we move to make cuda-python a meta package, it is better that we do not copy/paste from each component's release note, but instead have clickable links to included components, which is why the release notes are more and more succinct as we make the transition. We want to avoid making mistakes in copy-pastas (which happened several times).
From this perspective, cuda-python 12.9.1/13.0.0 release notes should look roughly identical.
The omission of cuda-pathfinder is arguably an issue:
cuda-pathfinder is considered a transitive dependency to cuda-python (from cuda-bindings), see here. Though it's probably a good idea to also include cuda-pathfinder in cuda-python[all]. I'll raise a PR.
These are expected because of the way this repository is set up to host multiple component packages. The diff is inevitably affected by other components that are considered irrelevant to the new tag (in this case, cuda.core).
Well, that is wrong, because the release archives (any of the 3 assets) contain all components: cuda_bindings, cuda_core, cuda_pathfinder, and the meta-package cuda_python 🤷
Well, that is wrong, because the release archives (any of the 3 assets) contain all components
I am not sure if you follow or if I wasn't being clear, quoting my reply from earlier:
These are expected because of the way this repository is set up to host multiple component packages. The diff is inevitably affected by other components that are considered irrelevant to the new tag (in this case, cuda.core).
We don't control the release artifacts associated with a git tag, certainly not those attached under https://github.com/NVIDIA/cuda-python/tags, Git/GitHub do. A git tag is repository-wide instead of covering a subset of directories. Once we tag, GitHub automatically generates and attaches them (the zip and the tarball) to a release. We can't even delete them when editing the release notes.
We can certainly attach more artifacts to a release ourselves (today we use a custom workflow which explains the third asset that you saw). But as far as source code is concerned, we just repeat what GitHub does (uploading a snapshot of the repo associated with the tag), mainly to avoid GitHub's own artifacts getting regenerated and leading the file hash changed (there's a long history behind this need). We need a stable file hash for downstream to consume.
Activity
lahwaacz commentedon Aug 10, 2025
There is at least 1 new Python package that needs to be documented properly in the release notes:
cuda.path_finderleofang commentedon Aug 11, 2025
Hi, thanks for reporting!
These are expected because of the way this repository is set up to host multiple component packages. The diff is inevitably affected by other components that are considered irrelevant to the new tag (in this case,
cuda.core).As for the
cuda-pythonrelease note, I have two comments:cuda-python12.9.1/13.0.0 release notes should look roughly identical.cuda-pathfinderis arguably an issue:cuda-pathfinderthat's linkable yet (Add Sphinx docs forcuda.pathfinder#760, cc @rwgk for vis)cuda-pathfinderis considered a transitive dependency tocuda-python(fromcuda-bindings), see here. Though it's probably a good idea to also includecuda-pathfinderincuda-python[all]. I'll raise a PR.lahwaacz commentedon Aug 11, 2025
But the CUDA Python 12.9.1 Release notes have only one item in the "Included components" section:
cuda.bindings. Why iscuda.coremissing when it causes such a huge diff? There should be a link tocuda.core0.3.1 Release Notes orcuda.core0.3.2 Release Notes.leofang commentedon Aug 11, 2025
Because cuda-core is not yet part of cuda-python, see #148 and cuda-python's setup.py linked earlier.
lahwaacz commentedon Aug 11, 2025
Well, that is wrong, because the release archives (any of the 3 assets) contain all components:
cuda_bindings,cuda_core,cuda_pathfinder, and the meta-packagecuda_python🤷leofang commentedon Aug 11, 2025
I am not sure if you follow or if I wasn't being clear, quoting my reply from earlier:
We don't control the release artifacts associated with a git tag, certainly not those attached under https://github.com/NVIDIA/cuda-python/tags, Git/GitHub do. A git tag is repository-wide instead of covering a subset of directories. Once we tag, GitHub automatically generates and attaches them (the zip and the tarball) to a release. We can't even delete them when editing the release notes.
We can certainly attach more artifacts to a release ourselves (today we use a custom workflow which explains the third asset that you saw). But as far as source code is concerned, we just repeat what GitHub does (uploading a snapshot of the repo associated with the tag), mainly to avoid GitHub's own artifacts getting regenerated and leading the file hash changed (there's a long history behind this need). We need a stable file hash for downstream to consume.