Skip to content

CI: Enforce type checks #312

Closed
Closed

Description

@leofang

We've introduced typing (Python type hints) support on Day 1 of the project, because it helps users understand cuda.core's API design logic. We should ensure our typing is done correctly (as far as mypy etc is concerned).

Activity

  1. added
    CI/CDCI/CD infrastructure
    cuda.coreEverything related to the cuda.core module
    enhancementAny code-related improvements
    P1Medium priority - Should do
    on Dec 18, 2024
  2. added this to the cuda.core beta 3 milestone on Dec 18, 2024
  3. leofang commented on Mar 4, 2025

    @leofang
    MemberAuthor

    Nontrivial mypy errors arose from @shwina investigation, from both 3rd and 1st party code. Pushing to beta 4.

  4. added
    cuda.coreEverything related to the cuda.core module
    and removed
    cuda.coreEverything related to the cuda.core module
    on Apr 2, 2026
  5. removed this from the cuda.core backlog milestone on Apr 2, 2026
  6. unmarked Make cuda.core pass mypy test #636 as a duplicate of this issue on Aug 20, 2026
  7. rparolin commented on Aug 20, 2026

    @rparolin
    Collaborator

    Closing as done. mypy-cuda-core is enforced in .pre-commit-config.yaml:139-165 (#2061): it is not in the ci: skip: list, it is green on HEAD via pre-commit.ci, and it is re-run --all-files by the required precommit-windows job (ci.yml:508-537).

    Two carve-outs remain, both about strictness rather than enforcement — the hook's ^cuda_core/cuda/.* filter skips cuda_core/tests, and the config is lenient (ignore_missing_imports = true, no disallow_untyped_defs for cuda_core). #636 was closed as a duplicate into this issue and covers exactly that scope, so I am reopening #636 to track it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    CI/CDCI/CD infrastructureP1Medium priority - Should docuda.coreEverything related to the cuda.core moduleenhancementAny code-related improvements

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions