Run pre-commit in the CI #255

Activity

1. leofang

   added

   CI/CDCI/CD infrastructureCI/CD infrastructure

   P0High priority - Must do!High priority - Must do!

   on Nov 27, 2024
2. leofang

   assigned

   shwina

   on Jan 5, 2025
3. shwina commented on Jan 14, 2025

   

   shwina

   on Jan 14, 2025

   Contributor

   More actions

   Do we want:

   1. To use pre-commit.ci? This is what CCCL uses for example.
   2. A new workflow in https://github.com/NVIDIA/cuda-python/tree/main/.github/workflows that invokes pre-commit?
   3. Something else?
4. leofang commented on Jan 14, 2025

   

   leofang

   on Jan 14, 2025

   Last edited by leofang

   MemberAuthor

   More actions

   I don't have strong opinions. Which would allow to stop building the packages if any of pre-commit checks fail? I don't think we want to even waste time building artifacts knowing the code would have to change later to meet the format & co requirements.
5. shwina

   closed this as completedin #396on Jan 15, 2025
6. leofang commented on Jan 15, 2025

   

   leofang

   on Jan 15, 2025

   MemberAuthor

   More actions

   Thanks, Ashwin! FWIW I made it a required check:

   

   in action:

   
7. leofang

   added this to the cuda-python 12-next, 11-next milestone on Jan 15, 2025