Skip to content

Should we remove tests/test_helpers.py?  #2471

Closed
Closed
Should we remove tests/test_helpers.py? #2471
Labels
triageNeeds the team's attention

Description

@lijinf2
lijinf2
opened on Jul 31, 2026

It looks falls into the scope of a previous decision that decided not to introduce tests for test helpers.

If test helpers do not work properly, let them throw errors in the CI. There was an issue #2174 tracking the discussion. @leofang

Activity

  1. github-actions
    added
    triageNeeds the team's attention
    on Jul 31, 2026

  2. Andy-Jost commented on Aug 13, 2026

    @Andy-Jost
    Andy-Jost
    on Aug 13, 2026
    Contributor

    This looks like a different issue. #2147 is about removing CI helpers that are no longer needed (i.e., not used by CI). In contrast, tests/test_helpers.py is about testing non-trivial test infrastructure that lives under tests/helpers/. IMO it makes sense to test such things directly, at our discretion.

  3. rparolin commented on Aug 14, 2026

    @rparolin
    rparolin
    on Aug 14, 2026
    Collaborator

    This thread appears resolved so I'm going to close it. If I'm mistaken please re-open this ticket.

  4. rparolin
    closed this as completedon Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    triageNeeds the team's attention

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions