You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
CI doesn't test the latest release of cuda_core against cuda_bindings main #2449
Hi @mdboom — looking at this today, it appears the “released cuda_core × main cuda_bindings” quadrant may already be covered by the nightly-cuda-core mode added in #2283:
ci-nightly.yml jobs test-cuda-core-linux-64 / test-cuda-core-windows
matrix rows with ENV.MODE: nightly-cuda-core in ci/test-matrix.yml
install path in test-wheel-{linux,windows}.yml: main pathfinder/bindings + released cuda-core from PyPI, then the released tag’s test suite
That runs on the nightly schedule, but not as part of PR CI (ci.yml).
Could you clarify the intended scope for this issue?
Thanks for confirming it's covered in the nightlies, @atiaomar1978-hub. IMHO, this is an important enough case that we should cover it in at least one PR-running configuration. EDIT: But we should get @leofang's thoughts before proceeding with an implementation.
Thanks @mdboom — that makes sense. Nightly coverage is good, but a PR-running check would catch regressions before merge.
I'm happy to work on this once @leofang weighs in. My thinking is to reuse the existing nightly-cuda-core path (released cuda-core from PyPI + main pathfinder/bindings) and wire a reduced matrix into PR CI when cuda_bindings / related paths change — similar to what #2283 added for nightlies.
Activity
atiaomar1978-hub commentedon Jul 31, 2026
Hi @mdboom — looking at this today, it appears the “released
cuda_core× maincuda_bindings” quadrant may already be covered by thenightly-cuda-coremode added in #2283:ci-nightly.ymljobstest-cuda-core-linux-64/test-cuda-core-windowsENV.MODE: nightly-cuda-coreinci/test-matrix.ymltest-wheel-{linux,windows}.yml: main pathfinder/bindings + releasedcuda-corefrom PyPI, then the released tag’s test suiteThat runs on the nightly schedule, but not as part of PR CI (
ci.yml).Could you clarify the intended scope for this issue?
nightly-cuda-corecheck into PR CI whencuda_bindings/ related paths change?Happy to help with (2) if that’s what’s needed.
rparolin commentedon Aug 13, 2026
@leofang for vis. Thoughts on this?
mdboom commentedon Aug 14, 2026
Thanks for confirming it's covered in the nightlies, @atiaomar1978-hub. IMHO, this is an important enough case that we should cover it in at least one PR-running configuration. EDIT: But we should get @leofang's thoughts before proceeding with an implementation.
atiaomar1978-hub commentedon Aug 14, 2026
Thanks @mdboom — that makes sense. Nightly coverage is good, but a PR-running check would catch regressions before merge.
I'm happy to work on this once @leofang weighs in. My thinking is to reuse the existing
nightly-cuda-corepath (releasedcuda-corefrom PyPI + main pathfinder/bindings) and wire a reduced matrix into PR CI whencuda_bindings/ related paths change — similar to what #2283 added for nightlies.Happy to draft a PR once direction is confirmed.
rparolin commentedon Aug 14, 2026
Hi @atiaomar1978-hub. Thanks for offering to tackle this issue. I've assigned you as the owner of this ticket.
Let us know if you have any questions.
atiaomar1978-hub commentedon Aug 14, 2026
Opened #2638 to wire the existing
nightly-cuda-coretest mode into PR CI when bindings-related paths change.What it does
test-cuda-core-linux-64toci.yml(linux-only, matching the "at least one PR-running configuration" ask)cuda-corefrom PyPI + PR-built pathfinder/bindings wheels from the current rundetect-changes.outputs.test_bindings; updates thechecksaggregator accordinglyci/tools/tests/test_ci_pr_cuda_core_compat.pyLocal verification
pytest -v --noconftest ci/tools/tests/test_ci_pr_cuda_core_compat.py— 6 passedNo RunPod needed — GPU tests run on existing self-hosted CI runners.
atiaomar1978-hub commentedon Aug 14, 2026
Update on #2638:
test-core: false/test-python: false) sonightly-cuda-corecan install PR-built wheelsruff formatfailure onci/tools/tests/test_ci_pr_cuda_core_compat.py(run https://results.pre-commit.ci/run/github/381173759/1786751697.7FNpRYiJSZCR8Xfq95KQYw)Local guardrail tests still pass (
pytest -v --noconftest ci/tools/tests/test_ci_pr_cuda_core_compat.py).style: ruff-format ci guardrail test (NVIDIA#2449)