Skip to content

Remove helper scripts and tests not exercised by CI #2174

Description

@leofang

While reviewing #2147 we noticed a few helper scripts and tests in the repo that are documented for developers (and AI agents) but aren't invoked by any CI workflow. They risk silently rotting because nothing validates them on a regular basis.

Stance: remove them, rather than wiring them into CI.

Reasoning: our CI/CD already runs the relevant tooling on every PR. Writing additional tests to validate that tooling is recursive — tests for tests, tests for tests for tests, and so on. There is no principled place to stop. If the CI/CD breaks, the team will see it immediately on the next PR and fix it. We should draw the line at the per-PR validation layer rather than maintain an orphaned meta-test suite.

Concrete examples

ci/tools/tests/

  • Contains test_check_release_notes.py and test_fetch_ctk_redistrib.py today (PR Fix release run lookup for annotated tags #2147 would add a third).
  • Listed in pytest.ini testpaths, so a developer who runs plain pytest from the repo root would collect them — but no CI job does that.
  • .github/workflows/release.yml has a Self-test release-notes checker step that runs pytest ci/tools/tests, but it is commented out.

scripts/run_tests.sh

  • Recommended in cuda_core/README.md and the per-package AGENTS.md files as the orchestrated way to run tests locally.
  • No .github/workflows/ job invokes it; CI uses inline pytest calls against specific dirs in test-wheel-linux.yml, test-wheel-windows.yml, and coverage.yml.
  • Its targets are hardcoded to pathfinder | bindings | core | smoke | all — there is no tools target, so it would not cover ci/tools/tests either.

Proposed action

  • Delete ci/tools/tests/ and the corresponding pytest.ini entry.
  • Delete scripts/run_tests.sh and drop / rewrite the README and AGENTS.md guidance that points at it.

-- Leo's bot

Activity

  1. added
    CI/CDCI/CD infrastructure
    triageNeeds the team's attention
    on Jun 6, 2026
  2. added theissue type on Jun 16, 2026
  3. added this to the cuda.core v1.1.0 milestone on Jun 24, 2026
  4. removed theissue type on Jun 27, 2026
  5. added
    P1Medium priority - Should do
    and removed
    triageNeeds the team's attention
    on Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

CI/CDCI/CD infrastructureP1Medium priority - Should do

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions