Skip to content

Remove trampoline modules from the old layout #161

Closed

Description

@leofang
No description provided.

Activity

  1. leofang commented on Oct 11, 2024

    @leofang
    MemberAuthor

    Blocked by #162. (For some reason GitHub created the issues in the wrong order...)

  2. added
    blockedThis task is currently blocked by other tasks
    on Oct 11, 2024
  3. added
    P0High priority - Must do!
    breakingBreaking changes are introduced
    and removed
    blockedThis task is currently blocked by other tasks
    on May 8, 2025
  4. self-assigned this
    on May 8, 2025
  5. leofang commented on May 13, 2025

    @leofang
    MemberAuthor

    The .pth files (_cuda_bindings_redirector.{pth,py}) should also be removed.

  6. leofang commented on Jun 2, 2025

    @leofang
    MemberAuthor

    We probably should pull this in (ex: 12.9.1). Wheel repair (#673) reveals that there are two copies of msvcp140.dll getting copied into the wheel

    ...
      inflating: cuda/msvcp140-a6d8da6c43532fb4dbf620e6318b0e3c.dll
    ...
      inflating: cuda_bindings.libs/msvcp140-a6d8da6c43532fb4dbf620e6318b0e3c.dll
    ...
    

    and the CI log has this warning:

      C:\Users\runneradmin\AppData\Local\Temp\cibw-run-1a7anrl5\cp310-win_amd64\build\venv\lib\site-packages\delvewheel\_wheel_repair.py:977: UserWarning: Namespace package cuda contains root-level extension modules cuda.cp310-win_amd64.pyd;cudart.cp310-win_amd64.pyd;ccuda.cp310-win_amd64.pyd;ccudart.cp310-win_amd64.pyd;nvrtc.cp310-win_amd64.pyd;cnvrtc.cp310-win_amd64.pyd and needs an extra copy of the vendored DLLs. To avoid duplicate DLLs, move extension modules into regular (non-namespace) packages.
    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P0High priority - Must do!breakingBreaking changes are introducedcuda.bindingsEverything related to the cuda.bindings module

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions