Repository navigation
docs(nvpair-errors): add normative service specification - #129
Open
Noah-Tervalon-Nvidia wants to merge 3 commits into
Open
Noah-Tervalon-Nvidia wants to merge 3 commits into
Noah-Tervalon-Nvidia wants to merge 3 commits into
Conversation
Add services/nvpair-errors/spec.md, derived from the Go source and its tests rather than the README, following the structure of the existing specs: sections 1-15, a 7.0 method and notification table, and a closing section on the process model, CLI, and build wiring. Peer sync is described as it runs today: every address a peer publishes is kept in the peer's own order, and the one to push to is confirmed by connecting and remembered until a transport failure retires it. Errors are relayed to the desktop client and nvpair-tui, and each nvpair-proxy engine facade is a producer. Documentation only. No Go file is touched and no version changes. Signed-off-by: Terve <[email protected]>
The cross-node endpoint serves only TLS (runHTTPServer wraps its listener in tls.NewListener over the cluster mesh) and pushes only to https:// URLs, but several labels still said plain HTTP. Call it HTTPS wherever the spec names the surface, the interface, or the port. Signed-off-by: Terve <[email protected]>
Two shutdown descriptions still named the TLS-only listener the HTTP server. Signed-off-by: Terve <[email protected]>
Noah-Tervalon-Nvidia
requested review from
kjlubick and
nvrithik
and removed request for
kjlubick
September 29, 2026 15:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
services/nvpair-errors/spec.md, the normative specification for the error store and its cross-node sync, derived from the Go source and its tests and following the structure of the existing specs.Peer sync is described as it runs today: every address a peer publishes is kept in the peer's own order, and the one to push to is confirmed by connecting and remembered until a transport failure retires it. Errors are relayed to the desktop client and
nvpair-tui, and eachnvpair-proxyengine facade is a producer. Open items record that the list does not survive a restart, that an entry with an emptynodeIdcannot be cleared, and that the installer opens UDP 5353 for a binary that opens no multicast socket.Release intent
Changelog title
n/a
Changelog body
n/a
Bumps
Scope
Documentation only: one new file. No Go, desktop, installer, or version changes. The open items above are recorded, not fixed.
Validation
node scripts/spdx-headers.mjspasses.develop.Risk
None at runtime.
spec.mdis normative, so please flag any statement that does not match the code.Checklist
git commit -s), certifying the Developer Certificate of Origin.services/versions.jsonis written by automation — do not edit it by hand.