ES TN Fixes for Issue #166#206
Merged
Merged
Conversation
Signed-off-by: Simon Zuberek <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Simon Zuberek <[email protected]>
…ext-processing into ES-TN-Fixes-081424
tbartley94
requested changes
Aug 14, 2024
Member
tbartley94
left a comment
tbartley94
left a comment
There was a problem hiding this comment.
Will approve after renaming in electronic
|
|
||
| symbols = [x[0] for x in load_labels(get_abs_path("data/electronic/symbols.tsv"))] | ||
| symbols = pynini.union(*symbols) | ||
| symbols_no_period = pynini.difference(symbols, dot) |
Member
There was a problem hiding this comment.
Use full_stop not dot Less ambiguity
Member
There was a problem hiding this comment.
Same for instances of period
Contributor
Author
There was a problem hiding this comment.
Renamed dot to full_stop as requested.
period is a string literal for .
| @@ -36,39 +52,55 @@ def __init__(self, deterministic: bool = True): | |||
| super().__init__(name="electronic", kind="classify", deterministic=deterministic) | |||
|
|
|||
| dot = pynini.accep(".") | |||
Member
There was a problem hiding this comment.
Why are you defining dot when you have period from the import?
Contributor
Author
There was a problem hiding this comment.
dot (renamed to full_stop) is an acceptor. The period from the import is a string.
Signed-off-by: Simon Zuberek <[email protected]>
Signed-off-by: Simon Zuberek <[email protected]>
for more information, see https://pre-commit.ci
tbartley94
previously approved these changes
Aug 14, 2024
| ] | ||
| symbols = [x[0] for x in load_labels(get_abs_path("data/electronic/symbols.tsv"))] | ||
| symbols = pynini.union(*symbols) | ||
| symbols_no_period = pynini.difference(symbols, full_stop_accep) |
Signed-off-by: Simon Zuberek <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Simon Zuberek <[email protected]>
ekmb
approved these changes
Aug 15, 2024
BuyuanCui
pushed a commit
that referenced
this pull request
Aug 20, 2024
* Fixes for Issue #166 Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updates the Copyright Header Signed-off-by: Simon Zuberek <[email protected]> * Renames variables in ELECTRONIC tagger Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updates to symbols_no_full_stop Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updates Jenkins Signed-off-by: Simon Zuberek <[email protected]> --------- Signed-off-by: Simon Zuberek <[email protected]> Signed-off-by: Simon Zuberek <[email protected]> Co-authored-by: Simon Zuberek <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Alex Cui <[email protected]>
BuyuanCui
pushed a commit
that referenced
this pull request
Sep 19, 2024
* Fixes for Issue #166 Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updates the Copyright Header Signed-off-by: Simon Zuberek <[email protected]> * Renames variables in ELECTRONIC tagger Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updates to symbols_no_full_stop Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updates Jenkins Signed-off-by: Simon Zuberek <[email protected]> --------- Signed-off-by: Simon Zuberek <[email protected]> Signed-off-by: Simon Zuberek <[email protected]> Co-authored-by: Simon Zuberek <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Alex Cui <[email protected]>
BuyuanCui
pushed a commit
that referenced
this pull request
Sep 26, 2024
* Fixes for Issue #166 Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updates the Copyright Header Signed-off-by: Simon Zuberek <[email protected]> * Renames variables in ELECTRONIC tagger Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updates to symbols_no_full_stop Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updates Jenkins Signed-off-by: Simon Zuberek <[email protected]> --------- Signed-off-by: Simon Zuberek <[email protected]> Signed-off-by: Simon Zuberek <[email protected]> Co-authored-by: Simon Zuberek <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Alex Cui <[email protected]>
BuyuanCui
pushed a commit
that referenced
this pull request
Sep 26, 2024
* Fixes for Issue #166 Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updates the Copyright Header Signed-off-by: Simon Zuberek <[email protected]> * Renames variables in ELECTRONIC tagger Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updates to symbols_no_full_stop Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updates Jenkins Signed-off-by: Simon Zuberek <[email protected]> --------- Signed-off-by: Simon Zuberek <[email protected]> Signed-off-by: Simon Zuberek <[email protected]> Co-authored-by: Simon Zuberek <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Alex Cui <[email protected]>
BuyuanCui
pushed a commit
that referenced
this pull request
Oct 16, 2024
* Fixes for Issue #166 Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updates the Copyright Header Signed-off-by: Simon Zuberek <[email protected]> * Renames variables in ELECTRONIC tagger Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updates to symbols_no_full_stop Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updates Jenkins Signed-off-by: Simon Zuberek <[email protected]> --------- Signed-off-by: Simon Zuberek <[email protected]> Signed-off-by: Simon Zuberek <[email protected]> Co-authored-by: Simon Zuberek <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Alex Cui <[email protected]>
ngachchi
pushed a commit
to ngachchi/NeMo-text-processing
that referenced
this pull request
Jun 23, 2025
* Fixes for Issue NVIDIA#166 Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updates the Copyright Header Signed-off-by: Simon Zuberek <[email protected]> * Renames variables in ELECTRONIC tagger Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updates to symbols_no_full_stop Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updates Jenkins Signed-off-by: Simon Zuberek <[email protected]> --------- Signed-off-by: Simon Zuberek <[email protected]> Signed-off-by: Simon Zuberek <[email protected]> Co-authored-by: Simon Zuberek <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Namrata Gachchi <[email protected]>
FredHaa
pushed a commit
to FredHaa/NeMo-text-processing
that referenced
this pull request
Aug 15, 2025
* Fixes for Issue NVIDIA#166 Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updates the Copyright Header Signed-off-by: Simon Zuberek <[email protected]> * Renames variables in ELECTRONIC tagger Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updates to symbols_no_full_stop Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updates Jenkins Signed-off-by: Simon Zuberek <[email protected]> --------- Signed-off-by: Simon Zuberek <[email protected]> Signed-off-by: Simon Zuberek <[email protected]> Co-authored-by: Simon Zuberek <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
mgrafu
pushed a commit
that referenced
this pull request
Mar 13, 2026
* Fixes for Issue #166 Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updates the Copyright Header Signed-off-by: Simon Zuberek <[email protected]> * Renames variables in ELECTRONIC tagger Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updates to symbols_no_full_stop Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updates Jenkins Signed-off-by: Simon Zuberek <[email protected]> --------- Signed-off-by: Simon Zuberek <[email protected]> Signed-off-by: Simon Zuberek <[email protected]> Co-authored-by: Simon Zuberek <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
The fix does the following:
@jensen).":"->"colon") throughout the "ELECTRONIC" class.Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.