Repository navigation
docs: add Draft Component term to glossary - #71
Merged
Merged
Conversation
Add note explaining components are runtime collaborators, not static code units. Co-Authored-By: Claude Opus 4.5 <[email protected]>
📝 WalkthroughWalkthroughA new glossary term "Draft Component" has been added to the domain terminology glossary. This term defines components in a minimal state that lack required information and have not been added to a graph, with a note that they are not validated against the schema due to expected validation failures. Changes
Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly Related PRs
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Deploying living-architecture with
|
| Latest commit: |
e1d7eae
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8716b496.living-architecture.pages.dev |
| Branch Preview URL: | https://issue-39-m2-d2-4-add-draft-c.living-architecture.pages.dev |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @docs/architecture/domain-terminology/contextive/definitions.glossary.yml:
- Around line 66-67: Update the "Draft Component" glossary entry so the
definition explicitly states that draft components have no connections and
therefore are not a valid Riviere graph; amend the existing text for the "Draft
Component" entry (the name: "Draft Component") to mention "no connections" and
the phrase "not a valid Riviere graph (no connections)" while retaining the
existing points about minimal state and lack of required fields and schema
validation.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
docs/architecture/domain-terminology/contextive/definitions.glossary.yml
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: CR
Repo: NTCoding/living-architecture PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-01-08T17:19:05.921Z
Learning: When discussing domain concepts, clarify terminology with the user and add new terms to `docs/architecture/domain-terminology/contextive/definitions.glossary.yml`
📚 Learning: 2026-01-08T17:19:05.921Z
Learnt from: CR
Repo: NTCoding/living-architecture PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-01-08T17:19:05.921Z
Learning: When discussing domain concepts, clarify terminology with the user and add new terms to `docs/architecture/domain-terminology/contextive/definitions.glossary.yml`
Applied to files:
docs/architecture/domain-terminology/contextive/definitions.glossary.yml
📚 Learning: 2026-01-08T07:05:01.746Z
Learnt from: CR
Repo: NTCoding/living-architecture PR: 0
File: packages/riviere-extract-conventions/CLAUDE.md:0-0
Timestamp: 2026-01-08T07:05:01.746Z
Learning: Configure ESLint to enforce component decorators on classes using the `require-component-decorator` rule from `living-architecture/riviere-extract-conventions/eslint-plugin`
Applied to files:
docs/architecture/domain-terminology/contextive/definitions.glossary.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Cloudflare Pages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39
Summary
Test plan
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.