Skip to content

chore: migrate dev workflow to deterministic agent packages - #304

Merged
NTCoding merged 1 commit into
mainfrom
migrate-workflow
Apr 13, 2026
Merged

chore: migrate dev workflow to deterministic agent packages#304
NTCoding merged 1 commit into
mainfrom
migrate-workflow

Conversation

@NTCoding

@NTCoding NTCoding commented Apr 13, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Owner

Summary

  • replace @ntcoding/agentic-workflow-builder in tools/dev-workflow-v2 with published @nt-ai-lab/deterministic-agent-workflow-* packages
  • update import specifiers and lockfile only, keeping consumer code behavior unchanged
  • verify the migrated workflow package usage with install, typecheck, tests, and eslint

Summary by CodeRabbit

  • Chores
    • Migrated workflow engine dependencies to a new deterministic agent workflow package suite. All existing functionality remains unchanged.

@coderabbitai

coderabbitai Bot commented Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6313ccc0-2bd2-4bf5-9226-3f3d27739671

📥 Commits

Reviewing files that changed from the base of the PR and between 5f9a816 and ae29fb6.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (21)
  • package.json
  • tools/dev-workflow-v2/package.json
  • tools/dev-workflow-v2/src/features/workflow/domain/fixtures/workflow-test-fixtures.ts
  • tools/dev-workflow-v2/src/features/workflow/domain/registry.ts
  • tools/dev-workflow-v2/src/features/workflow/domain/states/addressing-feedback.ts
  • tools/dev-workflow-v2/src/features/workflow/domain/states/awaiting-ci.ts
  • tools/dev-workflow-v2/src/features/workflow/domain/states/blocked.ts
  • tools/dev-workflow-v2/src/features/workflow/domain/states/checking-feedback.ts
  • tools/dev-workflow-v2/src/features/workflow/domain/states/implementing.ts
  • tools/dev-workflow-v2/src/features/workflow/domain/states/reflecting.ts
  • tools/dev-workflow-v2/src/features/workflow/domain/states/reviewing.ts
  • tools/dev-workflow-v2/src/features/workflow/domain/states/submitting-pr.ts
  • tools/dev-workflow-v2/src/features/workflow/domain/workflow-types.ts
  • tools/dev-workflow-v2/src/features/workflow/domain/workflow.ts
  • tools/dev-workflow-v2/src/features/workflow/entrypoint/fixtures/workflow-cli-test-fixtures.ts
  • tools/dev-workflow-v2/src/features/workflow/entrypoint/workflow-cli.ts
  • tools/dev-workflow-v2/src/features/workflow/infra/external-clients/git/git.ts
  • tools/dev-workflow-v2/src/features/workflow/infra/persistence/workflow-definition.spec.ts
  • tools/dev-workflow-v2/src/features/workflow/infra/persistence/workflow-definition.ts
  • tools/dev-workflow-v2/src/shell/cli.ts
  • tools/dev-workflow-v2/src/shell/opencode-plugin.ts
📝 Walkthrough

Walkthrough

This PR migrates the tools/dev-workflow-v2 package from a single monolithic @ntcoding/agentic-workflow-builder dependency to six modular @nt-ai-lab/deterministic-agent-workflow-* packages. All import statements across domain, infrastructure, and shell layers are updated to reference the new package locations while preserving existing logic and interfaces.

Changes

Cohort / File(s) Summary
Root and project dependencies
package.json, tools/dev-workflow-v2/package.json		 Removed @ntcoding/agentic-workflow-builder from pnpm's ignoredBuiltDependencies list; replaced single dependency with six new @nt-ai-lab/deterministic-agent-workflow-* packages (cli, dsl, engine, event-store, claude-code, opencode) all pinned to version 0.1.5.
Domain state definitions
tools/dev-workflow-v2/src/features/workflow/domain/states/...		 Updated DSL imports in addressing-feedback, awaiting-ci, blocked, checking-feedback, implementing, reflecting, reviewing, and submitting-pr state modules from @ntcoding/agentic-workflow-builder/dsl to @nt-ai-lab/deterministic-agent-workflow-dsl; transition logic and exports unchanged.
Domain types and fixtures
tools/dev-workflow-v2/src/features/workflow/domain/{workflow-types,workflow,registry}.ts, tools/dev-workflow-v2/src/features/workflow/domain/fixtures/workflow-test-fixtures.ts		 Updated imports for WorkflowStateDefinition, BaseEvent, WorkflowStateError, pass, fail, and defineRecordingOps from old to new deterministic packages; fixture structure and exported APIs remain unchanged.
Infrastructure and external clients
tools/dev-workflow-v2/src/features/workflow/infra/external-clients/git/git.ts, tools/dev-workflow-v2/src/features/workflow/infra/persistence/...		 Updated GitInfo, BaseEvent, WorkflowStateError, and TransitionContext type imports from old agentic-workflow-builder modules to new deterministic-agent-workflow modules; function signatures and test logic preserved.
Entrypoint and CLI layer
tools/dev-workflow-v2/src/features/workflow/entrypoint/{fixtures/workflow-cli-test-fixtures.ts,workflow-cli.ts}, tools/dev-workflow-v2/src/shell/{cli.ts,opencode-plugin.ts}		 Updated imports for WorkflowEngineDeps, createStore, createWorkflowRunner, defineRoutes, arg, createDefaultProcessDeps, createClaudeCodeWorkflowCli, and createOpenCodeWorkflowPlugin from old packages to corresponding new deterministic-agent-workflow packages; dependency wiring and configuration unchanged.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested labels

Review effort 4/5

Poem

🐰 From agentic dreams to workflows deterministic,
Swapped old imports for packages new and systematic,
Each state and type now sources anew,
The logic remains—just the addresses flew!
Hop along with the refactor so clean and pragmatic! 🌟

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: migrating the dev workflow from the internal agentic-workflow-builder to published deterministic-agent packages.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch migrate-workflow

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 OpenGrep (1.17.0)
tools/dev-workflow-v2/src/features/workflow/domain/registry.ts

┌──────────────┐
│ Opengrep CLI │
└──────────────┘

�[32m✔�[39m �[1mOpengrep OSS�[0m
�[32m✔�[39m Basic security coverage for first-party code vulnerabilities.

�[1m Loading rules from local config...�[0m

tools/dev-workflow-v2/src/features/workflow/domain/states/addressing-feedback.ts

┌──────────────┐
│ Opengrep CLI │
└──────────────┘

�[32m✔�[39m �[1mOpengrep OSS�[0m
�[32m✔�[39m Basic security coverage for first-party code vulnerabilities.

�[1m Loading rules from local config...�[0m

package.json

┌──────────────┐
│ Opengrep CLI │
└──────────────┘

�[32m✔�[39m �[1mOpengrep OSS�[0m
�[32m✔�[39m Basic security coverage for first-party code vulnerabilities.

�[1m Loading rules from local config...�[0m

  • 18 others

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

sonarqubecloud Bot commented Apr 13, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@NTCoding
NTCoding merged commit cfaab38 into main Apr 13, 2026
17 checks passed
NTCoding added a commit that referenced this pull request Apr 13, 2026
@NTCoding =
chore: migrate dev workflow to deterministic agent packages (#304)
7531b06
@coderabbitai coderabbitai Bot mentioned this pull request Apr 13, 2026
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Apr 26, 2026
Merged
This was referenced Aug 12, 2026
Merged
Merged
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Aug 20, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

1 participant

@NTCoding