Skip to content

feat(workflow): extract reusable dev-workflow commands - #299

Merged
NTCoding merged 5 commits into
mainfrom
feat/dev-workflow-v2-reusable-commands
Aug 11, 2026
Merged

NTCoding merged 5 commits into
mainfrom
feat/dev-workflow-v2-reusable-commands

Conversation

@NTCoding

@NTCoding NTCoding commented Apr 12, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • add reusable /dev-workflow-v2:code-review, /dev-workflow-v2:list-review-threads, and /dev-workflow-v2:create-pr command definitions
  • update REVIEWING, CHECKING_FEEDBACK, and SUBMITTING_PR state instructions to invoke those extracted commands
  • document the new commands in the plugin README and bump the plugin patch version so the changes are picked up

Context

Several dev-workflow-v2 capabilities were only described inside workflow state files, which made them hard to reuse outside the state machine. This change lifts those review, PR feedback, and PR creation behaviors into dedicated commands while keeping workflow-specific recording and transitions in the state docs.

Traceability

  • PRD: —
  • PRD Section: —

Verification

git diff --check

Summary by CodeRabbit

  • Documentation

    • Added reusable workflow guidance for code reviews, unresolved review-thread listing, and pull request creation.
    • Documented dedicated commands for reviewing changes, inspecting unresolved threads, and creating pull requests.
    • Clarified workflow requirements, validation, failure handling, and read-only review-thread reporting.
    • Simplified reviewing and pull request submission instructions by directing users to the appropriate workflow commands.
  • Chores

    • Updated the workflow plugin version to 0.0.143.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Apr 12, 2026 •

Copy link
Copy Markdown

Deploying living-architecture with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1e0e01b
Status: ✅  Deploy successful!
Preview URL: https://926ad52c.living-architecture.pages.dev
Branch Preview URL: https://feat-dev-workflow-v2-reusabl.living-architecture.pages.dev

View logs

@coderabbitai

coderabbitai Bot commented Apr 12, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@NTCoding, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 33 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e57f986a-a56b-4891-af2e-73f518d6b07a

📥 Commits

Reviewing files that changed from the base of the PR and between 2eaf010 and 1e0e01b.

📒 Files selected for processing (3)
  • tools/dev-workflow-v2/commands/code-review.md
  • tools/dev-workflow-v2/commands/create-pr.md
  • tools/dev-workflow-v2/commands/list-review-threads.md
📝 Walkthrough

Walkthrough

The PR adds dev-workflow-v2 command documentation for code reviews, unresolved review threads, and pull request creation. It simplifies the REVIEWING and SUBMITTING_PR states, updates the README, and increments the plugin version.

Changes

Dev workflow command centralization

Layer / File(s) Summary
Review command specifications
tools/dev-workflow-v2/commands/code-review.md, tools/dev-workflow-v2/commands/list-review-threads.md
Defines review execution, payload validation and recording, failure handling, and unresolved review-thread reporting.
Pull request submission command
tools/dev-workflow-v2/commands/create-pr.md
Defines branch inspection, pull request creation and recording, output requirements, and prohibited direct operations.
State integration and command documentation
tools/dev-workflow-v2/states/reviewing.md, tools/dev-workflow-v2/states/submitting_pr.md, tools/dev-workflow-v2/README.md, tools/dev-workflow-v2/.claude-plugin/plugin.json
Updates state instructions, documents the commands, and increments the plugin version.

Estimated code review effort: 2 (Simple) | ~15 minutes

Possibly related PRs

Suggested labels: Review effort 2/5

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change and context but omits most required template sections, including acceptance criteria, validation results, design decisions, and out-of-scope details. Rewrite the description using all required template sections and include observable acceptance criteria plus validation results or explicitly explain unavailable checks.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes extracting reusable dev-workflow commands, which is the primary change.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/dev-workflow-v2-reusable-commands

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 7

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tools/dev-workflow-v2/commands/code-review.md`:
- Around line 14-18: Update the workflow steps that read state and build the
review prompt to fetch the recorded issue body whenever taskCheckPassed is false
and githubIssue is present, before invoking task-check. Include the fetched body
in the shared prompt as clearly delimited data, alongside the existing
githubIssue reference.
- Around line 20-21: Update the review-recording instruction around the agent
payload validation flow to pass review JSON safely as a single argument even
when summary or findings contain apostrophes. Use robust shell escaping or the
supported stdin/file transport with /dev-workflow-v2:workflow record-review,
while preserving validation and BLOCKED behavior for failed or invalid agents.

In `@tools/dev-workflow-v2/commands/create-pr.md`:
- Around line 16-19: Update the workflow after the branch inspection commands in
the PR creation instructions to check whether the merge-base diff contains any
changes and stop immediately when it is empty. Only continue drafting, pushing,
and creating the pull request when the branch has a non-empty diff.
- Around line 13-15: Update the workflow create-pr logic around
currentStateMachineState, githubIssue, featureBranch, and prNumber to reconcile
an existing GitHub pull request for featureBranch before creating a new one,
reusing and persisting its prNumber when found; otherwise create the pull
request and persist pr-recorded, ensuring retries after partial persistence
cannot create duplicates.
- Around line 19-32: Update the workflow instructions around step 5 and the
create-pr command so the agent fetches the issue title and body as delimited,
untrusted context, explicitly ignores instructions contained within them, and
passes each generated PR field as a separate safely quoted argument without
shell interpolation. Preserve the existing PR field requirements and workflow
command.

In `@tools/dev-workflow-v2/commands/list-review-threads.md`:
- Around line 15-23: Update the GraphQL workflow in the review-thread listing
instructions to paginate the reviews, reviewThreads, and each thread’s comments
connections using hasNextPage and endCursor until all pages are traversed. When
determining each thread’s primary summary, select the comment with the latest
createdAt rather than relying on incomplete or returned ordering.

In `@tools/dev-workflow-v2/states/reviewing.md`:
- Around line 13-16: Update the review workflow around review-recorded and the
SUBMITTING_PR transition to bind every verdict to the current review run and
repository HEAD. Persist the run identifier and commit SHA with each review
result, and allow submission only when one complete required-review bundle
matches both the active run and current HEAD; otherwise clear or ignore stale
verdicts when a new run begins.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 9b46973e-54a3-4b0c-a6fd-e7fde75225f3

📥 Commits

Reviewing files that changed from the base of the PR and between 9aff6b7 and 2eaf010.

📒 Files selected for processing (7)
  • tools/dev-workflow-v2/.claude-plugin/plugin.json
  • tools/dev-workflow-v2/README.md
  • tools/dev-workflow-v2/commands/code-review.md
  • tools/dev-workflow-v2/commands/create-pr.md
  • tools/dev-workflow-v2/commands/list-review-threads.md
  • tools/dev-workflow-v2/states/reviewing.md
  • tools/dev-workflow-v2/states/submitting_pr.md

Comment thread tools/dev-workflow-v2/commands/code-review.md Outdated
Comment thread tools/dev-workflow-v2/commands/code-review.md Outdated
Comment thread tools/dev-workflow-v2/commands/create-pr.md
Comment thread tools/dev-workflow-v2/commands/create-pr.md Outdated
Comment thread tools/dev-workflow-v2/commands/create-pr.md Outdated
Comment thread tools/dev-workflow-v2/commands/list-review-threads.md Outdated
Comment thread tools/dev-workflow-v2/states/reviewing.md
@sonarqubecloud

Copy link
Copy Markdown

@NTCoding
NTCoding merged commit b415ea2 into main Aug 11, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant