fix(extract): restore component enrichment coverage by NTCoding · Pull Request #287 · NTCoding/living-architecture

NTCoding · 2026-04-10T20:03:05Z

Summary

restore fromProperty extraction for method-based components
add regression coverage for class and method-based component enrichment
extend Vitest timeouts/pool settings for extract packages

Verification

git commit ran the repo verification hook successfully

Summary by CodeRabbit

Bug Fixes
- Improved validation of extraction rules for class-based components; unsupported extraction rule types now properly return errors instead of attempting invalid operations.
Tests
- Added test coverage for method-based component extraction.
- Extended test timeout limits for increased reliability.

coderabbitai · 2026-04-10T20:03:12Z

📝 Walkthrough

Walkthrough

The PR extends Vitest test timeouts to 60 seconds across two packages, adds test coverage for method-based component extraction and unsupported extraction rule error handling, refactors extraction rule evaluation logic to handle fromProperty rules at the top level rather than within class-based evaluation, and updates build dependencies for the role-check Nx target.

Changes

Cohort / File(s)	Summary
Test Configuration `packages/riviere-cli/vitest.config.mts`, `packages/riviere-extract-ts/vitest.config.mts`	Extended per-test timeout from default/15,000ms to explicit 60,000ms across both packages.
Extraction Tests `packages/riviere-extract-ts/src/features/extraction/domain/value-extraction/enrich-components-method-extraction.spec.ts`, `packages/riviere-extract-ts/src/features/extraction/domain/value-extraction/enrich-components.spec.ts`	Added new test cases: method-based component extraction with `fromProperty` enrichment of `subscribedEvents` metadata, and error handling validation for unsupported `fromMethodSignature` extraction on class-based components.
Extraction Logic `packages/riviere-extract-ts/src/features/extraction/domain/value-extraction/enrich-components.ts`	Refactored rule evaluation: `evaluateClassRule` now unconditionally throws error for unsupported rules; `evaluateRule` explicitly handles `fromProperty` rules before `fromParameterType` by resolving containing class and delegating appropriately.
Build Configuration `packages/riviere-extract-ts/project.json`	Added `@living-architecture/riviere-role-enforcement:build` as execution dependency for `role-check` Nx target alongside existing `^build`.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

fix(extract-conventions): switch event handler detection from interface to decorator #283: Both PRs switch subscribedEvents extraction to use fromProperty with corresponding test coverage and adjust rule evaluation handling for class-based components.
fix(extract-conventions): increase testTimeout for typed ESLint tests #258: Both PRs increase Vitest per-test timeout by updating testTimeout property in package vitest.config.mts files.
feat(riviere-extract-ts): add TypeScript component extractor #67: Both PRs modify packages/riviere-extract-ts/vitest.config.mts—the earlier PR introduces the file while this PR updates its testTimeout value.

Suggested labels

Review effort 3/5

Poem

🐰 The rules now flow in clearer streams,
FromProperty finds its rightful place,
Tests bloom with sixty-second dreams,
While extraction quickens up its pace!

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(extract): restore component enrichment coverage' directly aligns with the PR's primary objective: restoring fromProperty extraction for method-based components and adding regression coverage for component enrichment.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix-bug-from-property

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 OpenGrep (1.17.0)

packages/riviere-extract-ts/project.json

┌──────────────┐
│ Opengrep CLI │
└──────────────┘

�[32m✔�[39m �[1mOpengrep OSS�[0m
�[32m✔�[39m Basic security coverage for first-party code vulnerabilities.

�[1m Loading rules from local config...�[0m

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cloudflare-workers-and-pages · 2026-04-10T20:04:30Z

Deploying living-architecture with Cloudflare Pages

Latest commit:	`ef5a56e`
Status:	✅ Deploy successful!
Preview URL:	https://209ea227.living-architecture.pages.dev
Branch Preview URL:	https://fix-bug-from-property.living-architecture.pages.dev

View logs

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.oxlintrc.role-enforcement.19177.1775724109108.json:
- Around line 17-373: The config object in the JSON lacks the required
roleDefinitionsDir property (required by config-reader.ts), causing schema
validation to fail; add a top-level "roleDefinitionsDir" string property to this
config (e.g., pointing to the directory that contains your role definition
files) so config-reader.ts can find role definitions and the Oxlint plugin can
validate successfully — update the object that contains
"configDir"/"configDisplayPath"/"layers"/"roles" to include roleDefinitionsDir.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: d626a616-bec8-4b75-afac-bda195f2bc74

📥 Commits

Reviewing files that changed from the base of the PR and between f726800 and c223c4e.

📒 Files selected for processing (6)

.oxlintrc.role-enforcement.19177.1775724109108.json
packages/riviere-cli/vitest.config.mts
packages/riviere-extract-ts/src/features/extraction/domain/value-extraction/enrich-components-method-extraction.spec.ts
packages/riviere-extract-ts/src/features/extraction/domain/value-extraction/enrich-components.spec.ts
packages/riviere-extract-ts/src/features/extraction/domain/value-extraction/enrich-components.ts
packages/riviere-extract-ts/vitest.config.mts

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@packages/riviere-extract-ts/project.json`:
- Line 6: The role-check target currently lists an invalid dependency
"@living-architecture/riviere-role-enforcement:build" in the dependsOn array;
remove that entry from the dependsOn list in
packages/riviere-extract-ts/project.json so the role-check target no longer
depends on a non-existent NX build target (the command still runs source with
"pnpm exec tsx packages/riviere-role-enforcement/src/shell/bin.ts" and does not
require a built artifact).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: b9d5fa62-d229-4467-8bef-25ef83c18c50

📥 Commits

Reviewing files that changed from the base of the PR and between c223c4e and ef5a56e.

📒 Files selected for processing (2)

packages/riviere-extract-ts/project.json
packages/riviere-extract-ts/vitest.config.mts

sonarqubecloud · 2026-04-10T21:04:04Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

fix(extract): restore component enrichment coverage

abd6977

= added 3 commits April 10, 2026 21:08

fix(ci): resolve role-check source imports

cc18801

revert(ci): restore original role-check commands

4c2309c

revert(ci): restore project.json formatting

3eafeb9

NTCoding marked this pull request as ready for review April 10, 2026 20:29

Merge branch 'main' into fix-bug-from-property

c223c4e

coderabbitai Bot requested changes Apr 10, 2026

View reviewed changes

Comment thread .oxlintrc.role-enforcement.36616.1775854583699.json Outdated

fix: add riviere-role-enforcement build dependency to role-check

62084f6

coderabbitai Bot approved these changes Apr 10, 2026

View reviewed changes

= added 3 commits April 10, 2026 21:58

fix: delete file

397c8ab

fix: delete file

0a43148

revert

ef5a56e

coderabbitai Bot requested changes Apr 10, 2026

View reviewed changes

Comment thread packages/riviere-extract-ts/project.json

coderabbitai Bot approved these changes Apr 10, 2026

View reviewed changes

NTCoding merged commit ce072e3 into main Apr 10, 2026
17 checks passed

This was referenced Apr 12, 2026

feat(extract): add HTTP client linking and conventions #290

Merged

fix: resolve httpCall cross-module route fallback #300

Merged

fix(riviere-role-enforcement): bundle with esbuild to fix Node ESM runtime resolution #303

Merged

Navigation Menu

Repository navigation

fix(extract): restore component enrichment coverage - #287

fix(extract): restore component enrichment coverage#287
NTCoding merged 9 commits into
mainfrom
fix-bug-from-property

NTCoding commented Apr 10, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Apr 10, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Poem

Uh oh!

cloudflare-workers-and-pages Bot commented Apr 10, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

sonarqubecloud Bot commented Apr 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

NTCoding commented Apr 10, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Poem

Uh oh!

cloudflare-workers-and-pages Bot commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying living-architecture with Cloudflare Pages

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud Bot commented Apr 10, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

NTCoding commented Apr 10, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 10, 2026 •

edited

Loading

cloudflare-workers-and-pages Bot commented Apr 10, 2026 •

edited

Loading