Skip to content

fix(extract-conventions): increase testTimeout for typed ESLint tests - #258

Merged
NTCoding merged 1 commit into
mainfrom
fix-typed-eslint-test-timeout-v2
Feb 7, 2026
Merged

fix(extract-conventions): increase testTimeout for typed ESLint tests#258
NTCoding merged 1 commit into
mainfrom
fix-typed-eslint-test-timeout-v2

Conversation

@NTCoding

@NTCoding NTCoding commented Feb 7, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Owner

Reverts the ineffective tsconfigRootDir change from #257. The actual fix is increasing testTimeout to 30s — typed rule-tester tests bootstrap a full TypeScript program via allowDefaultProject, which takes ~9s on CI runners (shared vCPU Ubuntu) vs ~2s locally.

Summary by CodeRabbit

  • Tests
    • Updated ESLint rule tester configuration for improved directory resolution handling.
    • Increased test timeout duration to accommodate longer-running tests.

= @claude
fix(extract-conventions): increase testTimeout for typed ESLint tests
e7470b2 
Reverts the ineffective tsconfigRootDir change from #257.
The actual fix is increasing testTimeout to 30s — typed rule-tester
tests bootstrap a full TypeScript program via allowDefaultProject,
which takes ~9s on CI runners (shared vCPU Ubuntu) vs ~2s locally.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@coderabbitai

coderabbitai Bot commented Feb 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This pull request simplifies the TypeScript configuration discovery in an ESLint rule test by removing path resolution logic and replaces it with a direct import meta reference, while also adding a test timeout configuration to the Vitest setup.

Changes

Cohort / File(s) Summary
ESLint Rule Test Configuration
packages/riviere-extract-conventions/src/eslint/event-publisher-method-signature.spec.ts		 Removed node:path import and simplified tsconfigRootDir resolution from path.resolve(import.meta.dirname, '../..') to import.meta.dirname, streamlining how the TypeScript project config is discovered for the rule tester.
Vitest Configuration
packages/riviere-extract-conventions/vitest.config.mts		 Added testTimeout property set to 30,000 milliseconds in the test configuration, extending the maximum duration allowed for test completion.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Poem

🐰 A hop through configs, paths now lean,
No need for layers in between,
The tests shall wait with grace so kind,
Thirty seconds—peace of mind!
Simpler paths, the rabbit's way. ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-typed-eslint-test-timeout-v2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@NTCoding
NTCoding merged commit e119a14 into main Feb 7, 2026
10 of 12 checks passed
@sonarqubecloud

sonarqubecloud Bot commented Feb 7, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@coderabbitai coderabbitai Bot mentioned this pull request Apr 10, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

1 participant

@NTCoding