fix: module resource name and validation logic for disabled state - #121
Merged
nhs-oliverslater merged 4 commits intoSep 30, 2026
Merged
Conversation
uzairharoon20
previously approved these changes
Sep 29, 2026
nhs-oliverslater
enabled auto-merge (squash)
September 29, 2026 16:33
…dation conditions for when module.this.enabled resolves to false
…rce name logic and enhance validation conditions for when module.this.enabled resolves to false
… resource name logic to conditionally set based on module.this.enabled
…lly handle module.enabled state for role policies and endpoint validation
nhs-oliverslater
force-pushed
the
fix/BCSS-99999-module-disable-optimisaton
branch
from
September 30, 2026 10:37
7eb8c6b to
618a1b2
Compare
gdcNHS
approved these changes
Sep 30, 2026
nhs-oliverslater
deleted the
fix/BCSS-99999-module-disable-optimisaton
branch
September 30, 2026 10:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update resource name logic and enhance validation conditions across multiple modules to handle cases when the module is disabled. This change ensures that resources are not created or validated unnecessarily when the module is not enabled.