Skip to content

Feature/gr ndsp 655 add check for ensuring that mandatory entities have at least 1 valid record - #163

Open
georgeRobertson wants to merge 1 commit into
release_v010from
feature/gr-ndsp-655-add_check_for_ensuring_that_mandatory_entities_have_at_least_1_valid_record
Open

Feature/gr ndsp 655 add check for ensuring that mandatory entities have at least 1 valid record#163
georgeRobertson wants to merge 1 commit into
release_v010from
feature/gr-ndsp-655-add_check_for_ensuring_that_mandatory_entities_have_at_least_1_valid_record

feat: add empty_entity check post filters for mandatory entities

c86b22a
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Sep 25, 2026 in 43s

Quality Gate passed

Issues
7 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 424 in src/dve/core_engine/backends/base/rules.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "list(...)[0]" with "next(iter(...))" to avoid materializing the entire iterable. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaDZZaF-z5PIa1mbuT2b&open=AaDZZaF-z5PIa1mbuT2b&pullRequest=163

Check warning on line 714 in src/dve/pipeline/pipeline.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this comprehension with passing the iterable to the collection constructor call 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaDZZaKiz5PIa1mbuT2d&open=AaDZZaKiz5PIa1mbuT2d&pullRequest=163

Check warning on line 344 in src/dve/core_engine/backends/implementations/spark/rules.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaDZZaDoz5PIa1mbuT2W&open=AaDZZaDoz5PIa1mbuT2W&pullRequest=163

Check warning on line 391 in src/dve/core_engine/backends/implementations/spark/rules.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaDZZaDoz5PIa1mbuT2Y&open=AaDZZaDoz5PIa1mbuT2Y&pullRequest=163

Check warning on line 385 in src/dve/core_engine/backends/implementations/spark/rules.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaDZZaDoz5PIa1mbuT2X&open=AaDZZaDoz5PIa1mbuT2X&pullRequest=163

Check failure on line 587 in src/dve/pipeline/pipeline.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaDZZaKiz5PIa1mbuT2c&open=AaDZZaKiz5PIa1mbuT2c&pullRequest=163

Check warning on line 414 in src/dve/core_engine/backends/base/rules.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "list(...)[0]" with "next(iter(...))" to avoid materializing the entire iterable. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AaDZZaF-z5PIa1mbuT2a&open=AaDZZaF-z5PIa1mbuT2a&pullRequest=163
View more details on SonarQubeCloud