Repository navigation
Fix Python SDLS client mismatches with CryptoLib - #104
Merged
Merged
Conversation
jppan-jpl
commented
Oct 12, 2026
jppan-jpl
commented
Contributor
- Replace distutils.util.strtobool (removed in Python 3.12)
- Map enums correctly: TC check_fecf used AOS_CHECK_FECF_*, AOS has_ecf=false used TM_NO_FECF, AOS has_ocf used TM OCF values
- Invert kmccryptoservice.verifyserver; unset/true now verifies TLS
- Free the frame CryptoLib allocates in apply_security_tc
- Pass tfvn as int, not a character code
- Require max_frame_length for TM/AOS and pass the real frame length to process_security_tm/aos so short frames are rejected
- Return the full max-length frame from apply_security_aos
- Let cryptolib.tc.* override deprecated process_tc.* keys
- Add optional cam_cookies to TC apply/process via the _cam entry points
- Fix hex() for TC segment headers, pad bytes, AOS IZ and optional FECF
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsConsider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
|
kgieselman-jpl
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.