Fix UI display issues and improve macOS Tahoe/Sequoia support by arsarsars1 · Pull Request #1827 · MonitorControl/MonitorControl

arsarsars1 · 2025-12-27T17:39:53Z

Overview

This PR addresses UI display issues and improves macOS Tahoe (15.x) / Sequoia compatibility, with follow-up fixes for OSD behavior, keyboard volume capture, and HUD lifecycle.

Changes Made

UI Fixes

Menu Bar Slider
- Redesigned layout: icon above slider (column style), left-aligned with the slider
- Increased view height for spacing; fixed icon/slider overlap
- Menu SF Symbols use palette configuration on macOS 12+ to avoid white “matting” around filled glyphs (e.g. brightness sun icon)
Preferences — Displays Tab
- Fixed truncated display friendly name field (taller field, better alignment with larger fonts)
Preferences — About Tab
- Fixed truncated application name label
Preferences — Keyboard Tab
- Accessibility troubleshooting UI (Help, Reset Accessibility via tccutil where applicable)
- Volume control: new option Standard keys (force capture) — always captures volume/mute media keys even when the default output device supports native macOS volume (same intent as community PR Add "Standard keys (force capture)" option to volume control dropdown #1846; included here to ship with Tahoe work)
- Volume control popup widened slightly to fit the new menu title

macOS Tahoe / Sequoia / 26 Support

Custom HUD for broken native OSD
- On macOS 26+, OSDUtils uses a custom HUD (CustomHUD.swift) instead of private OSDManager where native OSD no longer shows reliable percentage/updates (per project README note on Tahoe)
- Fade-out uses RunLoop common mode so the timer still fires during nested run-loop activity
- Removed unused SwiftUI import from CustomHUD.swift
HUD lifecycle
- DisplayManager.clearDisplays() calls CustomHUDManager.cleanupDisplay per display so HUD windows/timers are not left behind after display reconnect or reconfigure
Slider
- Fixed percentage label updates (removed tautological percentageBox guard)

Files Touched (high level)

MonitorControl/Support/CustomHUD.swift — custom OSD UI
MonitorControl/Support/OSDUtils.swift — route to custom HUD on macOS 26+
MonitorControl/Support/SliderHandler.swift — menu slider layout & symbol rendering; percentage label fix
MonitorControl/Support/DisplayManager.swift — HUD cleanup when clearing displays
MonitorControl/Support/MediaKeyTapManager.swift — KeyboardVolume.mediaForce handling
MonitorControl/Enums/PrefKey.swift — mediaForce case
MonitorControl/Support/AppDelegate.swift, OnboardingViewController.swift — accessibility prompts include force-capture volume mode
MonitorControl/UI/Base.lproj/Main.storyboard, MonitorControl/UI/en.lproj/Main.strings — new volume menu item + layout
MonitorControl.xcodeproj/project.pbxproj, Info.plist files — project / version as needed

Testing

Tested on macOS Tahoe 15.x (UI, sliders, prefs, accessibility flow)
Verify custom HUD on macOS 26+ when adjusting brightness/volume/contrast
Verify Standard keys (force capture) keeps volume keys on MonitorControl when system would otherwise own them
Unplug/replug or reconfigure displays and confirm no stray HUD windows

- **Menu Bar Slider**: - Redesigned layout to column style (icon above slider). - Aligned icon to left-start. - Increased vertical spacing and view height for better touch target and aesthetics. - Fixed icon vs slider overlap issues. - **Preferences UI**: - **Displays**: Fixed truncated friendly name text field, increased height, and improved vertical alignment. - **About**: Fixed truncated app name text. - **Keyboard**: Improved layout of accessibility troubleshooting buttons (Help/Reset), added container/label for better grid alignment. - **macOS Tahoe Support**: - Added accessibility permission reset functionality. - Implemented Custom HUD fallback for cases where native OSD is broken.

waydabber · 2026-02-09T09:04:48Z

Hi @arsarsars1,

thank you for the pull request, I really appreciate it.

I am not sure I am entirely comfortable with the new menu layout, having the icons above the slider looks kind-of Strange (if we'd like to follow Tahoe style, maybe a min/max icon at both end of the slider might be better. Also, the super-small knob feels a bit strange:

Regarding the OSD, it might need some things to iron out. There seem to be white corners (beyond the rounding) and the yellow brightness icon does not seem to fully follow the macOS vibe.

Because of this, I am not yet ready to accept this PR just yet, but I leave it hanging here. But again, I appreciate your work, I just recommend iterating a bit on this.

sidevesh · 2026-04-05T12:35:29Z

@arsarsars1 are you planning on addressing the above issues ?

arsarsars1 · 2026-04-06T07:57:16Z

Hi @sidevesh, I will resolve the issues in the PR today. Thank you

Made-with: Cursor # Conflicts: # MonitorControl/UI/cs.lproj/Localizable.strings

Made-with: Cursor

- Updated CFBundleVersion in Info.plist files for both MonitorControl and MonitorControlHelper. - Adjusted HUD dimensions and layout in CustomHUD.swift for improved aesthetics. - Enhanced SliderHandler to support accent fill for better visual distinction in menu symbols.

- Add KeyboardVolume.mediaForce and UI for always capturing volume/mute keys - Clean up CustomHUD windows when displays are cleared - Fix SliderHandler percentage label update (remove tautology check) - CustomHUD: RunLoop.common timer, drop unused SwiftUI import - Widen volume control popup for new menu item; en Main.strings Made-with: Cursor

arsarsars1 · 2026-04-06T09:17:01Z

Hi @waydabber, the pr is updated. Thank you

- Draw the original soft ring + inner edge on BlockBorderOverlayView so the pre–visual-effect border look returns without relying on layer draw. - Use NSVisualEffectView material .menu and blending .withinWindow so the card matches standard NSMenu rows (replacing .popover / .behindWindow). - Light appearance uses a separator stroke instead of a white fill over the blurred material. - Bump CFBundleVersion to 7182 in app and helper Info.plist. Made-with: Cursor

arsarsars1 · 2026-04-06T10:30:16Z

Latest push (f403b30): Display block menu chrome

Restored the original multi-ring + inner-edge border via BlockBorderOverlayView (layer-backed NSVisualEffectView does not draw borders the old way).
Switched block material from .popover / .behindWindow to .menu / .withinWindow so the card matches the standard menu background next to the display name row.
Light mode: separator stroke instead of white fill over the blur.
CFBundleVersion → 7182 (app + helper).

sidevesh · 2026-04-12T01:26:34Z

@waydabber can we get this pr in now that @arsarsars1 has fixed the issues ?

arsarsars1 · 2026-04-12T14:06:35Z

@sidevesh yeah, the issue was fixed. It's ready for review. Thank you

waydabber · 2026-04-12T14:32:04Z

Hi all, sorry for being slow will this, I'll review soon and let you know if there is anything else.

arsarsars1 added 2 commits December 27, 2025 10:53

Bump build version

40f9b02

waydabber added feedback needed from reporter Waiting for issue reporter to provide feedback (see comments) in progress Issue currently being worked on and removed feedback needed from reporter Waiting for issue reporter to provide feedback (see comments) labels Feb 9, 2026

waydabber mentioned this pull request Apr 5, 2026

OSD slider not displayed on MacOS Tahoe #1782

Open

3 tasks

arsarsars1 added 4 commits April 6, 2026 13:00

Merge upstream/main into feat/tahoe-compatibility

3a583e6

Made-with: Cursor # Conflicts: # MonitorControl/UI/cs.lproj/Localizable.strings

chore: ignore Xcode and SwiftPM local build directories

8bbef39

Made-with: Cursor

shuntagami mentioned this pull request Apr 13, 2026

Add "Standard keys (force capture)" option to volume control dropdown #1846

Open

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix UI display issues and improve macOS Tahoe/Sequoia support#1827

Fix UI display issues and improve macOS Tahoe/Sequoia support#1827
arsarsars1 wants to merge 7 commits intoMonitorControl:mainfrom
arsarsars1:feat/tahoe-compatibility

arsarsars1 commented Dec 27, 2025 •

edited

Loading

Uh oh!

waydabber commented Feb 9, 2026

Uh oh!

sidevesh commented Apr 5, 2026

Uh oh!

arsarsars1 commented Apr 6, 2026

Uh oh!

arsarsars1 commented Apr 6, 2026

Uh oh!

arsarsars1 commented Apr 6, 2026

Uh oh!

sidevesh commented Apr 12, 2026

Uh oh!

arsarsars1 commented Apr 12, 2026

Uh oh!

waydabber commented Apr 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

arsarsars1 commented Dec 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Changes Made

UI Fixes

macOS Tahoe / Sequoia / 26 Support

Files Touched (high level)

Testing

Related

Uh oh!

waydabber commented Feb 9, 2026

Uh oh!

sidevesh commented Apr 5, 2026

Uh oh!

arsarsars1 commented Apr 6, 2026

Uh oh!

arsarsars1 commented Apr 6, 2026

Uh oh!

arsarsars1 commented Apr 6, 2026

Uh oh!

sidevesh commented Apr 12, 2026

Uh oh!

arsarsars1 commented Apr 12, 2026

Uh oh!

waydabber commented Apr 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

arsarsars1 commented Dec 27, 2025 •

edited

Loading