ArduinoOTA: don't crash on unrecognized packets - #4086
Merged
Merged
Conversation
devyte
approved these changes
Jan 4, 2018
Collaborator
|
Nice job figuring this out! |
Contributor
|
@Juppit Yes, that solve the problem. And an observation, in the function readStringUntil, now value is an integer but later it is compared with two char ('\ 0' and end). From my little knowledge, I think this is better to leave it as it was. |
Contributor
Author
Oops, I didn’t notice that. I’m not used to
I believe these are fine. |
Collaborator
|
I missed that as well. If someone makes a PR, I'll look at it and merge it asap. |
This was referenced Jan 4, 2018
devyte
pushed a commit
that referenced
this pull request
Jan 4, 2018
incosystem
pushed a commit
to incosys/Arduino
that referenced
this pull request
Jan 8, 2018
* ArduinoOTA: handle end of packet in readStringUntil fixes esp8266#3912 * ArduinoOTA: fix buffer overflow in parseInt fixes esp8266#3912
incosystem
pushed a commit
to incosys/Arduino
that referenced
this pull request
Jan 8, 2018
* Update ArduinoOTA.cpp * Update ArduinoOTA.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.