Repository navigation
Моя первая проектная работа - #1
Open
MobileDevel0per wants to merge 3 commits into
Open
MobileDevel0per wants to merge 3 commits into
MobileDevel0per wants to merge 3 commits into
Conversation
Comment on lines
+4
to
+5
| private String name; | ||
| private int speed; |
There was a problem hiding this comment.
Эти переменные можно пометить final и убрать геттеры - получится то же самое, но меньше кода
| } | ||
|
|
||
| public int distanceIn24H() { | ||
| return speed * 24; // Формула: Дистанция = время (24) * скорость (вводит пользователь). |
There was a problem hiding this comment.
время лучше вынести в константу для повышения читабельности кода
| System.out.println("Hello world!"); | ||
| Scanner scanner = new Scanner(System.in); | ||
| Race race = new Race(); | ||
| Car[] cars = new Car[3]; |
There was a problem hiding this comment.
От хранения массива машин и лишнего цикла при определении победителя можно избавиться, если при вводе данных сразу вычислять победителя и хранить его в отдельной переменной, тогда программа будет требовать меньше памяти и работать быстрее
Owner
Author
|
Посмотрел на ютубе что возможно использовать catch для решения проблемы с буквенными значениями, исправил |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Провел все необходимые редакции кода, старался оставить удобные комментарии и имена.
Программа проверена на работоспособность, отвечает всем необходимым требованиям.