Support stopOnEntry and launchInTerminal in launch.json - #177
Merged
Merged
Conversation
Jinbo Wang (testforstephen)
commented
Nov 27, 2017
Jinbo Wang (testforstephen)
commented
Contributor
- Add stopOnEntry in launch.json
- Add console for lauchInTerminal feature in launch.json
Signed-off-by: Jinbo Wang <[email protected]>
Signed-off-by: Jinbo Wang <[email protected]>
Yaohai Zheng (yaohaizh)
suggested changes
Nov 27, 2017
| - `cwd` - The working directory of the program. | ||
| - `env` - The extra environment variables for the program. | ||
| - `stopOnEntry` - Automatically stop program after launch. | ||
| - `console` - Where to launch the program. Defaults to `internalConsole`. |
Contributor
There was a problem hiding this comment.
Is this term console provide by VSCode? Normally, in this case, it will call as shell?
Contributor
Author
There was a problem hiding this comment.
reference to vscode-node-debug implemented by vscode team, they used the term console.
Member
There was a problem hiding this comment.
The specified console to launch the program. Defaults to ...
| "enumDescriptions": [ | ||
| "VS Code Debug Console (which doesn't support to read input from a program)", | ||
| "VS Code's integrated terminal", | ||
| "external terminal that can be configured via user settings" |
| "externalTerminal" | ||
| ], | ||
| "enumDescriptions": [ | ||
| "VS Code Debug Console (which doesn't support to read input from a program)", |
Contributor
There was a problem hiding this comment.
support doing
…jinbo_launchInTerminal
Rome Li (akaroml)
requested changes
Nov 29, 2017
| - `cwd` - The working directory of the program. | ||
| - `env` - The extra environment variables for the program. | ||
| - `stopOnEntry` - Automatically stop program after launch. | ||
| - `console` - Where to launch the program. Defaults to `internalConsole`. |
Member
There was a problem hiding this comment.
The specified console to launch the program. Defaults to ...
| - `stopOnEntry` - Automatically stop program after launch. | ||
| - `console` - Where to launch the program. Defaults to `internalConsole`. | ||
| - `internalConsole` - VS Code Debug Console (which doesn't support reading input from a program) | ||
| - `integratedTerminal` - VS Code's integrated terminal |
Member
There was a problem hiding this comment.
VS Code integrated terminal.
| - `env` - The extra environment variables for the program. | ||
| - `stopOnEntry` - Automatically stop program after launch. | ||
| - `console` - Where to launch the program. Defaults to `internalConsole`. | ||
| - `internalConsole` - VS Code Debug Console (which doesn't support reading input from a program) |
Member
There was a problem hiding this comment.
VS Code debug console (input stream not supported).
| - `console` - Where to launch the program. Defaults to `internalConsole`. | ||
| - `internalConsole` - VS Code Debug Console (which doesn't support reading input from a program) | ||
| - `integratedTerminal` - VS Code's integrated terminal | ||
| - `externalTerminal` - External terminal that can be configured via user settings |
| }, | ||
| "stopOnEntry": { | ||
| "type": "boolean", | ||
| "description": "Automatically stop program after launch.", |
Member
There was a problem hiding this comment.
Automatically pause the program after launching.
| "type": "string", | ||
| "enum": [ | ||
| "internalConsole", | ||
| "integratedTerminal", |
| "externalTerminal" | ||
| ], | ||
| "enumDescriptions": [ | ||
| "VS Code Debug Console (which doesn't support reading input from a program)", |
Member
There was a problem hiding this comment.
Please change accordingly.
Rome Li (akaroml)
approved these changes
Nov 29, 2017
Yaohai Zheng (yaohaizh)
approved these changes
Nov 29, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.