Fix perf issue when debugging pet clinic with "stopOnEntry" on - #115
Merged
Merged
Conversation
Signed-off-by: Jinbo Wang <[email protected]>
Jinbo Wang (testforstephen)
requested review from
Rome Li (akaroml),
Andy Xu(devdiv) (andxu) and
Xuan Zhou (ansyral)
November 22, 2017 03:17
| Method method = ((MethodEntryEvent) debugEvent.event).method(); | ||
| if (method.isPublic() && method.isStatic() && method.name().equals("main") | ||
| && method.signature().equals("([Ljava/lang/String;)V")) { | ||
| debugSession.getVM().eventRequestManager().deleteEventRequest(request); |
Contributor
There was a problem hiding this comment.
add vmdisconnected exception handle on deleteEventRequest
Andy Xu(devdiv) (andxu)
approved these changes
Nov 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang [email protected]
fix bug: 100% CPU when debugging sprint boot pet clinic with "stopOnEntry" on (microsoft/vscode-java-debug#145).
The root cause: previous implementation doesn't clean up the methodEntryRequest when the stopOnEntry is hit. The later program always do string compare to filter if it's the main method. This is the reason why stopOnEntry slow down the debuggee program.