build_mpos.sh: fix macOS build on Clang 21#142
Open
bitcoin3us wants to merge 1 commit into
Open
Conversation
Clang 21 added -Wunterminated-string-initialization, which fails the -Werror build when compiling secp256k1's intentionally non-null-terminated bip340_algo[13] tag. Extend the existing macOS Clang warning suppression with -Wno-error=unterminated-string-initialization. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clang 21 added
-Wunterminated-string-initialization. Under the build's-Werror, the macOS build fails compilingsecp256k1:bip340_algo[13]is an intentionally non-null-terminated 13-byte tag insecp256k1. This extends the existing macOS Clang warning-suppression line inbuild_mpos.shwith-Wno-error=unterminated-string-initialization, matching thegnu-folding-constant/missing-field-initializerssuppressions already on that line.Test plan
scripts/build_mpos.sh macOScompletes and produceslvgl_micropy_macOSon Clang 21🤖 Generated with Claude Code