Add "esp32-small" build target#111
Conversation
Seems to be just another hacky way to expand the build process. Maybe the whole thing should be restructured? The idea is to add a target for CYD that has 4MB flash and no PSRAM. On the other side the normal "esp32" build runs here ... So i really don't know it it's needed...
|
Thanks! The diff seems bigger than it should, lots of lines that are "changed" without any change... I would suggest keeping the diff minimal, for clarify, making the review easy etc :-) How do you mean, not sure if it's needed? It seems to overlap with the unphone one indeed, except maybe the 4 vs 8MB flash size, so indeed, maybe not needed, or could be smaller... Should we wait for the CYD pull request to come out of "draft" before merging this one? |
| echo "Example: $0 esp32-small" | ||
| echo "Example: $0 esp32s3" | ||
| echo "Example: $0 unphone" | ||
| echo "Example: $0 clean" |
There was a problem hiding this comment.
This are only whitespace changes and the added esp32-small line
It's only about whitespace changes. Think it's a good idea to add a EDIT: EditorConfig added here: #113 |
|
I see, thank you! I would suggest separating functional from big yet non-functional changes (like whitespace or reordering stuff) into separate pull requests or commits, just to make it easier to review and the diff smaller, or to be able to merge one without merging the other. It's fine for now, just something to be aware of :-) |
2 participants
Seems to be just another hacky way to expand the build process. Maybe the whole thing should be restructured?
The idea is to add a target for CYD that has 4MB flash and no PSRAM. On the other side the normal "esp32" build runs here ... So i really don't know it it's needed...