Check and fix app manifest files#105
Conversation
Enforce same format for all app manifest files via tests with `indent=2, ensure_ascii=False, sort_keys=True` Based on MicroPythonOS#105
|
@ThomasFarstrike Whoops, why does the test pass here: https://github.com/MicroPythonOS/MicroPythonOS/actions/runs/23763550334/job/69237124833?pr=105#step:9:3142 
I remove |
I recognize that some app didn't download, so I implement this test and found and fixed some bugs ;)
It seems like the test doesn't pass... because there's no module named "packaging"... |
|
This is a great addition! |
Yes. But the question is, why is the pipeline is still green? |
|
Ah yes, the pipeline doesn't become red and stop because sometimes it's useful to have it still continue and have the other artifacts for testing. There's no easy way to have it become red AND continue... But we had the same annoyance in another pull request - a test fails but the total pipeline succeeds, and we miss the failure. So perhaps it's time to have it fail when a test fails... |
|
maybe split the workflows?!? |
2 participants
I recognize that some app didn't download, so I implement this test and found and fixed some bugs ;)