Fix run_desktop.sh greedy sed regex eating other JSON keys#104
Merged
ThomasFarstrike merged 1 commit intoMar 30, 2026
Merged
Conversation
The sed pattern "auto_start_app": ".*" uses greedy matching, which on a single-line JSON file matches from the first quote after the key to the last quote on the line, destroying any subsequent JSON keys (e.g. theme_light_dark). Change .* to [^"]* so it only matches the value within quotes. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Contributor
|
You're sending pull requests faster than I can merge then! :-D |
Contributor
Author
|
Thank you Thomas. Excited for your next release candidate =D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_desktop.shusessedto updateauto_start_appin the JSON config file"auto_start_app": ".*"uses greedy.*which matches to the last quote on the line, destroying any subsequent JSON keys (e.g.theme_light_dark,number_format).*to[^"]*so it only matches within the value's quotesExample
Before fix, running
run_desktop.sh com.example.appon:{"auto_start_app": "old.app", "theme_light_dark": "dark"}produces:
{"auto_start_app": "com.example.app"}(theme_light_dark is gone)
After fix, it correctly produces:
{"auto_start_app": "com.example.app", "theme_light_dark": "dark"}Test plan
auto_start_apprun_desktop.sh <appname>and verify other keys are preserved🤖 Generated with Claude Code