InputManager: mark emulate_focus_obj(group,o) as deprecated in favor of lv.group_focus_obj(o)

ThomasFarstrike · ThomasFarstrike · commit 74a9400be7ff · 2026-05-22T12:37:51.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,14 +3,16 @@ Future release (next version)
 
 Put unreleased changes here!
 
+
 Builtin Apps:
-- Bundle these as compiled bytecode .mpy files to reduce build size by 60KiB and improve performance
+- Bundle as compiled bytecode .mpy files to reduce build size by 60KiB and improve performance
 - About: show system uptime
 - HowTo app: make import lvgl as lv explicit
 
 Frameworks:
 - AppManager: try .mpy after .py and use import instead of explicit compile
 - AppManager: require explicit import lvgl for clarity
+- InputManager: mark emulate_focus_obj(group,o) as deprecated in favor of lv.group_focus_obj(o)
 - SharedPreferences: avoid writing default-only configs at boot and prune empty config dirs/files
 
 OS:
diff --git a/internal_filesystem/apps/com.micropythonos.file_manager/assets/file_manager.py b/internal_filesystem/apps/com.micropythonos.file_manager/assets/file_manager.py
@@ -1,6 +1,6 @@
 import os
 import lvgl as lv
-from mpos import Activity, InputManager, Intent, sdcard
+from mpos import Activity, Intent, sdcard
 from rename_activity import RenameActivity
 
 
@@ -117,7 +117,7 @@ def _focus_action_bar(self):
             return
         group = lv.group_get_default()
         if group:
-            InputManager.emulate_focus_obj(group, self._cancel_btn)
+            lv.group_focus_obj(self._cancel_btn)
 
     def _show_action_bar(self):
         self._dismiss_action_bar()
diff --git a/internal_filesystem/lib/mpos/ui/focus_direction.py b/internal_filesystem/lib/mpos/ui/focus_direction.py
@@ -145,7 +145,6 @@ def process_object(obj, depth=0):
     return closest_obj
 
 def move_focus_direction(angle):
-    from .input_manager import InputManager
     focus_group = lv.group_get_default()
     if not focus_group:
         print("move_focus_direction: no default focus_group found, returning...")
@@ -174,4 +173,4 @@ def move_focus_direction(angle):
     if o:
         #print("move_focus_direction: moving focus to:")
         #mpos.util.print_lvgl_widget(o)
-        InputManager.emulate_focus_obj(focus_group, o)
+        lv.group_focus_obj(o)
diff --git a/internal_filesystem/lib/mpos/ui/input_manager.py b/internal_filesystem/lib/mpos/ui/input_manager.py
@@ -85,20 +85,17 @@ def pointer_xy(cls):
     @classmethod
     def emulate_focus_obj(cls, focusgroup, target):
         """
-        Emulate setting focus to a specific object in the focus group.
-        This function is needed because the current version of LVGL doesn't have a direct set_focus method.
-        It should exist, according to the API, so maybe it will be available in the next release and this function might no longer be needed someday.
+        Deprecated compatibility shim.
+
+        Use lv.group_focus_obj(target) directly.
         """
-        if not focusgroup:
-            print("emulate_focus_obj needs a focusgroup, returning...")
-            return
         if not target:
             print("emulate_focus_obj needs a target, returning...")
             return
-        for objnr in range(focusgroup.get_obj_count()):
-            currently_focused = focusgroup.get_focused()
-            if currently_focused is target:
-                return
-            else:
-                focusgroup.focus_next()
-        print("WARNING: emulate_focus_obj failed to find target")
+
+        print(
+            "WARNING: InputManager.emulate_focus_obj() is deprecated and unnecessary. "
+            "Use lv.group_focus_obj(target) directly."
+        )
+
+        lv.group_focus_obj(target)
diff --git a/internal_filesystem/lib/mpos/ui/keyboard.py b/internal_filesystem/lib/mpos/ui/keyboard.py
@@ -248,9 +248,7 @@ def scroll_after_show(self, timer):
     def focus_on_keyboard(self, timer=None):
         default_group = lv.group_get_default()
         if default_group:
-            from .input_manager import InputManager
-            from .focus_direction import move_focus_direction
-            InputManager.emulate_focus_obj(default_group, self._keyboard)
+            lv.group_focus_obj(self._keyboard)
 
     def scroll_back_after_hide(self, timer):
         self._parent.scroll_to_y(self._saved_scroll_y, True)
diff --git a/internal_filesystem/lib/mpos/ui/view.py b/internal_filesystem/lib/mpos/ui/view.py
@@ -97,8 +97,7 @@ def back_screen():
     if default_group:
         from .focus import move_focusgroup_objects
         move_focusgroup_objects(prev_focusgroup, default_group)
-        from .input_manager import InputManager
-        InputManager.emulate_focus_obj(default_group, prev_focused)
+        lv.group_focus_obj(prev_focused)
 
     if prev_activity:
         prev_activity.onResume(prev_screen)
