Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
hmalik88
marked this pull request as ready for review
September 23, 2026 15:33
hmalik88
requested a deployment
to
default-branch
September 23, 2026 15:33 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The package template manifest remains stale, and the public breaking change and dependency upgrade are not fully documented or tested.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (4)
What changed in this PR
Adds batched state-key retrieval to snap-networks-utils and upgrades Snaps SDK/platform versions to support it.
Changes:
- Adds
getKeysto state interfaces and implementations. - Adds tests and updates state-manager mocks.
- Upgrades Snaps SDK dependencies, manifests, lockfile, and changelogs.
| File | Description |
|---|---|
package.json |
Updates the SDK resolution. |
yarn.lock |
Locks Snaps SDK 12.1.0. |
scripts/create-package/snap-template/package.json |
Updates the template SDK dependency. |
packages/snap-networks-utils/src/utils/state/State.ts |
Implements batched state reads. |
packages/snap-networks-utils/src/utils/state/State.test.ts |
Tests State.getKeys. |
packages/snap-networks-utils/src/utils/state/IStateManager.ts |
Adds the getKeys contract. |
packages/snap-networks-utils/src/utils/state/InMemoryState.ts |
Implements in-memory batch reads. |
packages/snap-networks-utils/src/utils/state/InMemoryState.test.ts |
Tests in-memory batch reads. |
packages/snap-networks-utils/package.json |
Upgrades the SDK dependency. |
packages/snap-networks-utils/CHANGELOG.md |
Documents getKeys. |
packages/bitcoin-wallet-snap/package.json |
Upgrades the SDK dependency. |
packages/bitcoin-wallet-snap/snap.manifest.json |
Updates the platform version. |
packages/bitcoin-wallet-snap/CHANGELOG.md |
Documents the SDK upgrade. |
packages/solana-wallet-snap/package.json |
Upgrades the SDK dependency. |
packages/solana-wallet-snap/snap.manifest.json |
Updates the platform version. |
packages/solana-wallet-snap/CHANGELOG.md |
Documents the SDK upgrade. |
packages/solana-wallet-snap/src/core/services/subscriptions/SubscriptionRepository.test.ts |
Updates a state-manager mock. |
packages/stellar-wallet-snap/package.json |
Upgrades the SDK dependency. |
packages/stellar-wallet-snap/snap.manifest.json |
Updates the platform version. |
packages/stellar-wallet-snap/CHANGELOG.md |
Documents the SDK upgrade. |
packages/stellar-wallet-snap/src/services/asset-metadata/AssetMetadataRepository.test.ts |
Updates a state-manager mock. |
packages/tron-wallet-snap/package.json |
Upgrades the SDK dependency. |
packages/tron-wallet-snap/snap.manifest.json |
Updates the platform version. |
packages/tron-wallet-snap/CHANGELOG.md |
Documents the SDK upgrade. |
packages/tron-wallet-snap/src/services/assets/AssetsRepository.test.ts |
Updates a state-manager mock. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Battambang
reviewed
Sep 23, 2026
|
Contributor
|
Networks team discussion prefers to have each snap its own isolated PR. |
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
snap_getStatewas updated to allow fetching of multiple keys from state at once. Accordingly, thegetKeysmethod is being added to theStateclass to benefit all snaps. This means less rpc calls, smaller payloads.References
N/A
Checklist