This repository was archived by the owner on Oct 7, 2024. It is now read-only.
added removeAccount#27
Merged
danfinlay merged 3 commits intoMetaMask:masterfrom Jul 12, 2018
Merged
Conversation
danfinlay
reviewed
Jul 12, 2018
| "eth-hd-keyring": "^1.2.2", | ||
| "eth-sig-util": "^1.4.0", | ||
| "eth-simple-keyring": "^1.2.2", | ||
| "eth-simple-keyring": "github:brunobar79/eth-simple-keyring#remove-account", |
danfinlay
approved these changes
Jul 12, 2018
Contributor
danfinlay
left a comment
danfinlay
left a comment
There was a problem hiding this comment.
Looks good! Had a question, but doesn't need to block, this should work with or without the latest trezor-keyring update.
| "eth-hd-keyring": "^1.2.2", | ||
| "eth-sig-util": "^1.4.0", | ||
| "eth-simple-keyring": "^1.2.2", | ||
| "eth-simple-keyring": "^1.3.0", |
Contributor
Author
There was a problem hiding this comment.
That's probably a good idea. Right now I'm adding the TrezorKeyring type in the metamask-controller (https://github.com/MetaMask/metamask-extension/pull/4625/files#diff-fd8e90928ae2cc670d306c0244a894d0R128)
If you're planning to add the multisig keyring here too then I should def. do it.
Contributor
There was a problem hiding this comment.
Oh right, it's included by consumers. That's fine with me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once MetaMask/eth-simple-keyring#11 gets merged I can update the version of eth-simple-keyring here