Repository navigation
Первый ПР к консольному приложению - #1
Open
Mereinalamone wants to merge 2 commits into
Open
Mereinalamone wants to merge 2 commits into
Mereinalamone wants to merge 2 commits into
Conversation
gusar-off
reviewed
Jul 31, 2023
| while (true) { | ||
| try { | ||
| Scanner scanner = new Scanner(System.in); | ||
| numberPeople = scanner.nextInt(); |
There was a problem hiding this comment.
hasNextInt
| while(true) { | ||
| try{ | ||
| System.out.printf("Введите название товара №%d: ", i); | ||
| Scanner scanner = new Scanner(System.in); |
There was a problem hiding this comment.
Лучшее переиспользовать инстанс Scanner, а не создавать каждый раз новый.
| try{ | ||
| System.out.printf("Введите цену товара №%d: ", i); | ||
| Scanner scanner = new Scanner(System.in); | ||
| price = scanner.nextFloat(); |
There was a problem hiding this comment.
Тоже самое, что и с hasNextInt только тут надо hasNextFloat
| } | ||
| System.out.println("Список добавленных товаров"); | ||
| System.out.println("|Наименование товара |Стоимость |"); | ||
| for (i = 0; i < productList.size(); i = i + 1) { |
There was a problem hiding this comment.
Можно воспользоваться циклом foreach, было бы удобнее, подробнее можно почитать тут
https://javarush.com/groups/posts/for-each-java
1) использовал методы hasNext() для обработки введённой пользователем инфармации 2) теперь переиспользуется инстанс Scanner, без пересоздания в каждом цикле как было
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Первый ПР к консольному приложению калькулятор счёта