Fix crash in GC: PyTuple_SET_ITEM steals reference#5
Merged
sboehmann merged 1 commit intoMeVisLab:masterfrom Sep 19, 2019
Merged
Fix crash in GC: PyTuple_SET_ITEM steals reference#5sboehmann merged 1 commit intoMeVisLab:masterfrom
sboehmann merged 1 commit intoMeVisLab:masterfrom
Conversation
Member
|
@iakov Thank you for the patch. Looks good and is merged now. |
|
Sorry to necropost, but what happened to commit 642b73e? I pulled from this repo today, and while I had that merge commit locally from earlier pulls, it seems to have vanished from this repo. GitHub says "This commit does not belong to any branch on this repository." |
Contributor
Author
|
At least the fix is still in the upstream's master. :) 963b667 |
|
Yeah, but if a commit exists in a branch, it's not expected to disappear since that messes up everybody's Git history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Py_Finalize crash is caused by references mishandling in Enums. This PR fixes the issue.