Conversation
Author
|
@mf2199 you have already reviewed, but for further updates plz review. |
mf2199
changed the title
emar-kar
approved these changes
Jul 31, 2019
| try: | ||
| table.create(column_families={"cf1": max_versions_rule}) | ||
| break | ||
| except Exception as e: |
There was a problem hiding this comment.
Maybe that is worth it, if possible, to determine the exception more specifically, instead of rising it through Exception?
Collaborator
There was a problem hiding this comment.
I agree on that, this should be under question. Exception is a base class for all exceptions in Python, so with this statement you'll catch errors of all kinds, while in issue they talk only about google.api_core.exceptions.DeadlineExceeded.
Collaborator
|
This can now be forwarded to a public PR. |
emar-kar
pushed a commit
that referenced
this pull request
Aug 15, 2019
…leapis#8720) * Checking in staged client helper code Additional test, docs & proposed cleanup needs to happen on top of this. * update create_model to allow user to specify included or excluded col… (#16) * update create_model to allow user to specify included or excluded columns * made minor changes stylistically and with added ValueError outputs * Update doc gen & module structure. Add unit & system tests * added two new func: set time, get table address (#23) * added two new func: set time, get table address * changed indentation * Add system tests * Address linter & python2.7 import errors * Passes **kwargs through to client & implements missing methods * Support BQ as input/output in batch_predict * Address first round of feedback * Switch to pytest.raises, fix .rst formatting exception * Make list system tests more stringent
emar-kar
pushed a commit
that referenced
this pull request
Sep 18, 2019
…leapis#8720) * Checking in staged client helper code Additional test, docs & proposed cleanup needs to happen on top of this. * update create_model to allow user to specify included or excluded col… (#16) * update create_model to allow user to specify included or excluded columns * made minor changes stylistically and with added ValueError outputs * Update doc gen & module structure. Add unit & system tests * added two new func: set time, get table address (#23) * added two new func: set time, get table address * changed indentation * Add system tests * Address linter & python2.7 import errors * Passes **kwargs through to client & implements missing methods * Support BQ as input/output in batch_predict * Address first round of feedback * Switch to pytest.raises, fix .rst formatting exception * Make list system tests more stringent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #8480
Preliminary discussion can be found here