Repository navigation
Спринт 2. Проектная работа №1. - #1
Open
Main-expert wants to merge 4 commits into
Open
Main-expert wants to merge 4 commits into
Main-expert wants to merge 4 commits into
Conversation
Comment on lines
+2
to
+3
| public String nameCar; // Название автомобиля | ||
| public int speed; // Скорость автомобиля |
There was a problem hiding this comment.
Поля лучше пометить final, тем самым исключив возможность их модификации извне
| System.out.println("Введите скорость машины №" + i + ":"); | ||
| if (scanner.hasNextInt()) { // Проверяем, что введено число | ||
| speed = scanner.nextInt(); | ||
| if (speed >= 0 && speed <= 250) { |
There was a problem hiding this comment.
Минимальную и максимальную скорости лучше вынести в константы с говорящим названием для повышения читабельности кода
|
|
||
| // Выводим победителя | ||
| System.out.println("Самая быстрая машина: " + race.currentLeader); | ||
| scanner.close(); // Закрываем Scanner |
There was a problem hiding this comment.
Молодец, что не забыл вызвать close() у объекта Scanner, заботиться об очистке ресурсов - очень важный навык
Comment on lines
+2
to
+3
| public String currentLeader = ""; // Текущий лидер | ||
| public int distanceLeader = 0; // Дистанция текущего лидера |
There was a problem hiding this comment.
Эти переменные лучше сделать приватными, чтобы у других классов не было возможности их изменения, а для получения названия машины-победителя лучше написать публичный геттер
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.