Skip to content

Raise TypeError for a bad subprocess pipe protocol owner #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gyanu2507 wants to merge 1 commit into
base: master
Choose a base branch
from
+28 −5
Open

Raise TypeError for a bad subprocess pipe protocol owner #767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions tests/test_subprocess_pipe_proto.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import unittest

from uvloop.loop import ReadSubprocessPipeProto, WriteSubprocessPipeProto


class TestSubprocessPipeProto(unittest.TestCase):
def test_rejects_non_process_owner(self):
with self.assertRaises(TypeError):
ReadSubprocessPipeProto(1, 7)
with self.assertRaises(TypeError):
WriteSubprocessPipeProto(1, 7)

def test_rejects_non_int_fd(self):
# Owner is checked first. A non-process still must not segfault.
with self.assertRaises(TypeError):
WriteSubprocessPipeProto(object(), 'nope')
17 changes: 12 additions & 5 deletions uvloop/handles/process.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,11 +706,18 @@ cdef class UVProcessTransport(UVProcess):
class WriteSubprocessPipeProto(aio_BaseProtocol):

def __init__(self, proc, fd):
if UVLOOP_DEBUG:
if type(proc) is not UVProcessTransport:
raise TypeError
if not isinstance(fd, int):
raise TypeError
# Release builds used to cast `proc` and segfault. Reject a bad owner
# here so a mistaken constructor argument is a TypeError.
if type(proc) is not UVProcessTransport:
raise TypeError(
'proc must be a UVProcessTransport, not {!r}'.format(
type(proc).__name__,
),
)
if not isinstance(fd, int):
raise TypeError(
'fd must be an int, not {!r}'.format(type(fd).__name__),
)
self.proc = proc
self.fd = fd
self.pipe = None
Expand Down
Loading