feat: update Transcoder API samples to v1 - #5784
Merged
Merged
Conversation
google-cla
Bot
added
the
cla: yes
product-auto-label
Bot
added
the
samples
telpirion
self-requested a review
August 12, 2021 18:02
telpirion
suggested changes
Aug 12, 2021
| try { | ||
| DeleteJobTemplate.deleteJobTemplate(PROJECT_ID, LOCATION, TEMPLATE_ID); | ||
| } catch (Exception e) { | ||
| // Don't worry if the template doesn't already exist. |
Contributor
There was a problem hiding this comment.
I don't know how I feel about this. We should be deterministic in our tests.
Contributor
Author
There was a problem hiding this comment.
The try block is there only to delete the job template if it exists. This is a very rare case since the test template uses a random UUID each time. I updated the catch block to only catch the common case where the template is not found. All other errors should fail the test.
telpirion
approved these changes
Aug 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes b:184919153
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only