Repository navigation
Conversation
Use a unit normalization factor for all-zero waveforms, so silent input stays silent instead of raising ZeroDivisionError (pure Python) or emitting invalid-value warnings (NumPy). Add tests that read back the WAV frames for NumPy and pure Python input, with and without normalization. AI assistance was used to investigate and prepare this change. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audio([0.0] * 16, rate=8000)computes a zero normalization factor for a silent waveform. The pure Python path raisesZeroDivisionError; the NumPy path emits invalid divide and cast warnings.This uses a factor of 1 for an all-zero waveform so the samples stay silent. Nonzero waveforms are still scaled by their maximum absolute value, and
normalize=Falsekeeps its existing range check.The new tests read back the WAV header and PCM frames for mono/stereo NumPy input and for mono input without NumPy, with normalization on and off.
🤖🤖 AI assistance was used to investigate and prepare this change.