Skip to content

Separating out parsing of ims and users during RTM client login#2

Merged
rawdigits merged 6 commits into
slackapi:masterfrom
Saberr:master
Feb 13, 2015
Merged

Separating out parsing of ims and users during RTM client login#2
rawdigits merged 6 commits into
slackapi:masterfrom
Saberr:master

Conversation

@wagmiwiz

Copy link
Copy Markdown
Contributor

This helps get the array of users filled so they it can be looked up later. It also separates ims from channels so that we can store realname (if present) and timezone.

@tangxingqin

Copy link
Copy Markdown

If call sc.api_call('api.test'), error raised:
TypeError: api_call() takes exactly 2 arguments (3 given)
So I think, _client.py line 22

return self.server.api_call(method, kwargs)

should be

return self.server.api_call(method, **kwargs)

? :)

@tals

tals commented Jan 13, 2015

Copy link
Copy Markdown

+1 to what @tangxingqin said. This library is busted right now because of this :(

@wagmiwiz

Copy link
Copy Markdown
Contributor Author

Hey guys, been away, I shall look into adding the fix to PR.
On 13 Jan 2015 01:16, "Tal Sh" [email protected] wrote:

+1 to what @tangxingqin https://github.com/tangxingqin said. This
library is busted right now because of this :(


Reply to this email directly or view it on GitHub
#2 (comment)
.

rawdigits added a commit that referenced this pull request Feb 13, 2015
Separating out parsing of ims and users during RTM client login
@rawdigits rawdigits merged commit 41ded52 into slackapi:master Feb 13, 2015
@rawdigits

Copy link
Copy Markdown
Contributor

Thanks for the fixes here and apologies on the delay getting this merged back into master.

c-goosen pushed a commit to c-goosen/python-slackclient that referenced this pull request Jun 18, 2019
Separating out parsing of ims and users during RTM client login
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants