Just to get an Actions run; don't merge this into master#669
Closed
dnwiebe wants to merge 31 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request appears to be refactoring cryptographic functionality throughout the MASQ Node codebase. Based on the title "Just to get an Actions run; don't merge this into master", this is a work-in-progress change intended for testing CI/CD pipelines rather than a production merge.
Key Changes:
- Refactor static
CryptDEreferences to use aCryptDEPairstruct containing main and alias cryptographic engines - Replace global static
main_cryptde()andalias_cryptde()functions with lazy-staticCRYPTDE_PAIRinstances - Add serialization/deserialization methods (
to_string,make_from_str) to CryptDE implementations - Remove the
Clonederive fromPersistentConfigurationMockand implement it manually to handle CryptDE cloning
Reviewed Changes
Copilot reviewed 53 out of 53 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| node/tests/initialization_test.rs | Adds new integration test and imports for CryptDE handling |
| node/src/test_utils/persistent_configuration_mock.rs | Removes Clone derive and adds manual Clone implementation with CryptDE methods |
| node/src/test_utils/neighborhood_test_utils.rs | Updates test utilities to use CryptDEPair parameter |
| node/src/test_utils/mod.rs | Replaces global CryptDE functions with lazy static CryptDEPair |
| node/src/sub_lib/stream_key.rs | Updates tests to use lazy static CryptDEPair |
| node/src/sub_lib/route.rs | Updates tests to use lazy static CryptDEPair |
| node/src/sub_lib/proxy_client.rs | Changes CryptDE field to CryptDEPair |
| node/src/sub_lib/neighborhood.rs | Updates Display trait implementations and test usage |
| node/src/sub_lib/hopper.rs | Changes cryptdes field to cryptde_pair and updates tests |
| node/src/sub_lib/hop.rs | Updates tests to use lazy static CryptDEPair |
| node/src/sub_lib/cryptde_real.rs | Adds serialization methods and updates as_any implementation |
| node/src/sub_lib/cryptde_null.rs | Adds serialization methods and updates tests |
| node/src/sub_lib/cryptde.rs | Adds serialization method signatures to CryptDE trait |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.