Skip to content

GH-672: payment adjuster infrastructure#348

Merged
bertllll merged 112 commits into
masterfrom
GH-672
Oct 13, 2023
Merged

GH-672: payment adjuster infrastructure#348
bertllll merged 112 commits into
masterfrom
GH-672

Conversation

@bertllll

Copy link
Copy Markdown
Contributor

No description provided.

Bert added 30 commits May 4, 2023 18:32
… tests for BlockchainInterfaceClandestine should be made first
… responsibility of the estimated gas limit from BchI to Chain
…gas price used for generating hashed transactions
Bert and others added 20 commits October 3, 2023 22:50
GH-600: Add get_block_number
GH-600: Address PR feedback
GH-585: Experiment with adapting test for platform specific error codes
GH-585: Provide Windows platform specific error code and message
GH-600: Rebase master into branch
* Starts Accountant
* Adds Receivables scan timeout (may become a configuration parameter in another card)
* Stores `max_block_count` in the config table when processing error messages providing a limit
* Adds Max Block Count to configuration response
* Increments CURRENT_SCHEMA_VERSION
* Adds schema migration for `max_block_count`
* Improves blockchain scan error handling and logging

@utkarshg6 utkarshg6 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the modifications in the following commits, and they exclusively involve straightforward name changes that are more generic in nature.

Comment thread node/src/blockchain/blockchain_interface/blockchain_interface_web3/mod.rs Outdated
Comment thread node/src/node_configurator/configurator.rs
Comment thread node/src/node_configurator/configurator.rs Outdated
fn handle(&mut self, msg: QualifiedPayablesMessage, _ctx: &mut Self::Context) {
self.handle_scan(
Self::handle_request_balances_to_pay_payables,
Self::handle_payable_payments_setup_msg_payload,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad name

Comment thread node/src/blockchain/blockchain_interface/blockchain_interface_web3/mod.rs Outdated
Comment thread node/src/node_configurator/configurator.rs
Comment thread node/src/node_configurator/configurator.rs
Comment thread node/src/node_configurator/configurator.rs
Comment thread node/src/node_configurator/configurator.rs Outdated

@utkarshg6 utkarshg6 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫠

@bertllll
bertllll merged commit b2d0b07 into master Oct 13, 2023
@bertllll
bertllll deleted the GH-672 branch October 13, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants