Skip to content

GH-580: test for data_directory_from_context with opt dir and implementation …#248

Merged
czarte merged 79 commits into
masterfrom
GH-580
Aug 21, 2023
Merged

GH-580: test for data_directory_from_context with opt dir and implementation …#248
czarte merged 79 commits into
masterfrom
GH-580

Conversation

@bertllll

Copy link
Copy Markdown
Contributor

…in fn

Comment thread node/src/node_configurator/mod.rs Outdated
Comment thread node/src/node_configurator/mod.rs Outdated
Comment thread node/src/node_configurator/mod.rs Outdated
Comment thread node/src/node_configurator/mod.rs Outdated
Comment thread node/src/node_configurator/mod.rs Outdated
@czarte
czarte requested a review from utkarshg6 April 4, 2023 07:59
@czarte czarte self-assigned this Apr 4, 2023

@bertllll bertllll left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take your time, no rush, address the comments and I'll be happy to see it again once done.

Comment thread .vscode/launch.json Outdated
Comment thread node/src/bootstrapper.rs Outdated
Comment thread node/src/daemon/setup_reporter.rs Outdated
Comment thread node/src/daemon/setup_reporter.rs Outdated
Comment thread node/src/daemon/setup_reporter.rs Outdated
Comment thread node/src/database/config_dumper.rs Outdated
Comment thread node/src/database/config_dumper.rs Outdated
Comment thread node/src/database/config_dumper.rs Outdated
Comment thread node/src/node_configurator/node_configurator_standard.rs Outdated
Comment thread node/src/node_configurator/node_configurator_standard.rs Outdated
@czarte
czarte marked this pull request as ready for review May 3, 2023 09:15
czarte and others added 7 commits May 5, 2023 18:46
…, test for chain specific directories uncompleted but passing
This reverts commit c0f205a.
…_when_user_specifies_data_directory_without_chain_specific_directory
…rver_initializer_collected_params_senses_when_user_specifies_data_directory_without_chain_specific_directory
@czarte
czarte merged commit 97dfbad into master Aug 21, 2023
@czarte
czarte deleted the GH-580 branch August 21, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants