Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: maxmind/GeoIP2-java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: LukeButters/GeoIP2-java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 7 commits
  • 4 files changed
  • 1 contributor

Commits on Oct 4, 2019

  1. Adds cityOrNull & countryOrNull methods for cases when the IP is unkn… 

    …own. #28

Throwing exceptions is expensive and should generally be reserved for
exceptional circumstances. This change adds to the DatabaseReader support
for returning null instead of an exception when the IP address is not found.
    Luke Butters committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    8582234 View commit details
    Browse the repository at this point in the history

  2. Fix typo in java doc

    Luke Butters committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    ceae379 View commit details
    Browse the repository at this point in the history

  3. Fix the assert call made in test

    Luke Butters committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    831746a View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2019

  1. Add the return null methods for all methods returned in DatabaseProvider 

    also switch to using try as we will start to use optional
    Luke Butters committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    56e64c9 View commit details
    Browse the repository at this point in the history

  2. The try methods now return Optional.

    Luke Butters committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    9e6d74c View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2019

  1. Support JDK8

    Luke Butters committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    2371227 View commit details
    Browse the repository at this point in the history

  2. Remove building on jdk7 it is no longer supported

    Luke Butters committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    4dfca84 View commit details
    Browse the repository at this point in the history
Loading