This repository was archived by the owner on Dec 14, 2023. It is now read-only.
Avoid using lock in emit - #29
Merged
StephenHynes7 merged 1 commit intoFeb 24, 2015
Merged
Conversation
Contributor
Author
There was a problem hiding this comment.
This lock is causing emit to be synchronised globally which is ineficient.
Because the lock is only to avoid double-starting the thread, and python checks this for us in threading, we can simply try to start it and catch the exception.
Contributor
There was a problem hiding this comment.
Sounds good, ill merge this in now.
Contributor
There was a problem hiding this comment.
Hi @graingert. I agreen with your arguments.
But, this change prevent the error, RuntimeError Exception threads can only be started once?
This error will now be handled by the logger of django for example?
Contributor
Author
There was a problem hiding this comment.
No it won't be logged because I've caught the exception.
StephenHynes7
pushed a commit
that referenced
this pull request
Feb 24, 2015
Avoid using lock in emit
StephenHynes7
pushed a commit
that referenced
this pull request
Feb 25, 2015
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.